Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect display of linked sugar AP R2 – base AP R1 in the Sequence mode #4608

Open
ViktoriaTkacheva opened this issue May 10, 2024 · 0 comments · May be fixed by #4886
Open

Incorrect display of linked sugar AP R2 – base AP R1 in the Sequence mode #4608

ViktoriaTkacheva opened this issue May 10, 2024 · 0 comments · May be fixed by #4886
Assignees
@DmitriiP-EPAM
Labels
bug Macromolecules Priority: Medium Sequence mode Bucket: Sequence mode related issues
Milestone
Refined Backlog

Comments

@ViktoriaTkacheva
Copy link
Collaborator

ViktoriaTkacheva commented May 10, 2024 •
edited by olganaz
Loading

Steps to Reproduce

  1. Switch to the Macro mode

  2. Draw any linked sugar AP R2 with a base AP R1
    image

  3. Switch to the Sequence mode

Actual behavior
Linked sugar AP R2 with a base AP R1 display as “@”
image

Expected behavior
Linked sugar AP R2 with a base AP R1 display as two “@” linked between each other
image

Desktop (please complete the following information):

  • OS: Windows 10 Pro (version 22H2) x64
  • Browser: Сhrome
  • Version: (124.0.6367.92) x64

Ketcher version 2.21.0-rc.2, Build at 2024-05-10; 05:30:51

Issue found while testing #3734

Alternatives
Any connection, except R2-R1 (R1-R2) between sugar and any monomer, except base (sugar, phosphate, peptide, chem) AND R3-R1 between sugar and base correspondingly are considered as side chain connections and displayed as straight line connecting two monomers center-to-center.
@ViktoriaTkacheva ViktoriaTkacheva added this to the Ketcher 2.23.0-rc.1 milestone May 10, 2024
@DmitriiP-EPAM DmitriiP-EPAM self-assigned this Jun 21, 2024
DmitriiP-EPAM added a commit that referenced this issue Jun 26, 2024
@DmitriiP-EPAM
#4608 - Bugfix (PolymerBond): Correct isSideChainConnection getter
1410b4a
@DmitriiP-EPAM DmitriiP-EPAM linked a pull request Jun 26, 2024 that will close this issue
WIP: #4608 – Incorrect display of linked sugar AP R2 – base AP R1 in the Sequence mode #4886
Draft
9 tasks
DmitriiP-EPAM added a commit that referenced this issue Jun 27, 2024
@DmitriiP-EPAM
#4608 - Bugfix (PolymerBond): Correct isSideChainConnection getter …
555cc28 
…(another requirement)
DmitriiP-EPAM added a commit that referenced this issue Jun 28, 2024
@DmitriiP-EPAM
#4608 - Bugfix (PolymerBond): Correct isSideChainConnection getter …
9641c56 
…(the third requirement)
DmitriiP-EPAM added a commit that referenced this issue Jul 4, 2024
@DmitriiP-EPAM
#4608 - Bugfix (PolymerBond): Correct isSideChainConnection getter …
dfa6641 
…(the third requirement) (amend)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitriiP-EPAM DmitriiP-EPAM

Labels
bug Macromolecules Priority: Medium Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Refined Backlog
3 participants
@rrodionov91 @ViktoriaTkacheva @DmitriiP-EPAM