Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching from Sequence mode to Flex mode and back shifts visible area of canvas beyond visible frame. #5115

Closed
AlexeyGirin opened this issue Jul 16, 2024 · 0 comments · Fixed by #6180
Closed

Switching from Sequence mode to Flex mode and back shifts visible area of canvas beyond visible frame. #5115

AlexeyGirin opened this issue Jul 16, 2024 · 0 comments · Fixed by #6180
Assignees
@Guch1g0v
Labels
bug Flex mode Bucket: Flex canvas related mode Priority: Medium Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 3.0.0-rc....

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jul 16, 2024 •
edited
Loading

Steps to Reproduce

  1. Go to Macromolecules - Flex mode <---Important!
  2. Load from file:
    Switching from Sequence mode to Snake mode and back shifts visible area of canvas beyond visible frame.zip
    image
  3. Switch view to Sequence mode
  4. Switch back to Flex mode

Actual behavior
Canvas forever shifted to the left and down partially beyond visibility frame
image

Expected behavior
No shifting
image

Environment details:

  • Ketcher Version 2.23.0-rc.3 Build at 2024-07-14; 20:34:10
  • Indigo Toolkit Version 1.22.0-rc.3.0-gbb5c51fc2-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Issue found while testing - #3532
@AlexeyGirin AlexeyGirin added bug Priority: Medium Sequence mode Bucket: Sequence mode related issues Flex mode Bucket: Flex canvas related mode labels Jul 16, 2024
@Guch1g0v Guch1g0v self-assigned this Dec 17, 2024
Guch1g0v added a commit that referenced this issue Dec 19, 2024
@Guch1g0v
#5115 - Switching from Sequence mode to Flex mode and back shifts vis…
a63f791 
…ible area of canvas beyond visible frame.
@Guch1g0v Guch1g0v linked a pull request Dec 19, 2024 that will close this issue
#5115 - Switching from Sequence mode to Flex mode and back shifts visible area of canvas beyond visible frame. #6180
Merged
9 tasks
Guch1g0v added a commit that referenced this issue Dec 21, 2024
@Guch1g0v
#5115 - Switching from Sequence mode to Flex mode and back shifts vis…
27d7608 
…ible area of canvas beyond visible frame.
Guch1g0v added a commit that referenced this issue Dec 25, 2024
@Guch1g0v
#5115 - Switching from Sequence mode to Flex mode and back shifts vis…
ccee3cd 
…ible area of canvas beyond visible frame.
Guch1g0v added a commit that referenced this issue Dec 26, 2024
@Guch1g0v
#5115 - Switching from Sequence mode to Flex mode and back shifts vis…
cd43061 
…ible area of canvas beyond visible frame.
Guch1g0v added a commit that referenced this issue Dec 30, 2024
@Guch1g0v
#5115 - Switching from Sequence mode to Flex mode and back shifts vis…
aa76407 
…ible area of canvas beyond visible frame.
NataliaLoginova pushed a commit that referenced this issue Dec 30, 2024
@Guch1g0v
#5115 - Switching from Sequence mode to Flex mode and back shifts vis…
204ba0c 
…ible area of canvas beyond visible frame. (#6180)

* #5115 - Switching from Sequence mode to Flex mode and back shifts visible area of canvas beyond visible frame.

* add check for the previous mode

* update playwright-report-macromolecules-1

* update playwright-report-macromolecules-3

* update playwright-report-macromolecules-4 part1

* update playwright-report-macromolecules-4 part2

* update tests

* update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guch1g0v Guch1g0v

Labels
bug Flex mode Bucket: Flex canvas related mode Priority: Medium Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Ketcher 3.0.0-rc.1 (Stability release)
3 participants
@rrodionov91 @AlexeyGirin @Guch1g0v