Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S-group in the middle of a chain does not expand when opening an SDF V3000 file #6185

Closed
Zhirnoff opened this issue Dec 20, 2024 · 1 comment · Fixed by #6208 or #6218
Closed

S-group in the middle of a chain does not expand when opening an SDF V3000 file #6185

Zhirnoff opened this issue Dec 20, 2024 · 1 comment · Fixed by #6208 or #6218
Assignees
@svvald
Labels
bug Export to SDF Bucket: Bugs related to Export to SDF Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: High Severity: High High level visibility to the user User's Feedback
Milestone
Ketcher 2.28.0-rc.4

Comments

@Zhirnoff
Copy link
Collaborator

Description: When opening an SDF file in V3000 format containing an Sgroup located in the middle of a chain, the Sgroup does not expand as expected. This issue disrupts the proper visualization of the structure and affects workflows requiring expanded Sgroups for analysis or editing.

Steps to Reproduce:

  1. Open Ketcher and load an SDF file in V3000 format File.zip
  2. Try to expand dC_2 S-group

Actual behavior
'Expand Abbreviation' menu is disabled. But for the other two S-groups, menu is accessible, and they can be expanded.
2024-12-20_13h56_21

Expected behavior
The S-group should expand to display its full structure within the chain.
2024-12-20_13h59_18

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.28.0-rc.3]
Indigo version
[Version 1.27.0-rc.1]
@Zhirnoff Zhirnoff added this to the Ketcher 2.28.0-rc.4 milestone Dec 20, 2024
@AlexeyGirin AlexeyGirin added Micromolecules canvas Bucket: Micromolecules canvas related issues Export to SDF Bucket: Bugs related to Export to SDF labels Dec 20, 2024
@svvald svvald self-assigned this Dec 24, 2024
svvald added a commit that referenced this issue Dec 24, 2024
@svvald
#6185 – Make SGroups expandable while placed within a chain
50d9e8f
svvald added a commit that referenced this issue Dec 25, 2024
@svvald
#6185 – Fix UI tests
4dc66a7
@svvald svvald linked a pull request Dec 25, 2024 that will close this issue
#6185 – Make SGroups expandable while placed within a chain #6208
Merged
9 tasks
svvald added a commit that referenced this issue Dec 25, 2024
@svvald
#6185 – Make SGroups expandable while placed within a chain (#6208)
c48ec4b 
* #6185 – Make SGroups expandable while placed within a chain

* #6185 – Fix UI tests
svvald added a commit that referenced this issue Dec 25, 2024
@svvald
Backmerge: #6185 – Make SGroups expandable while placed within a chain
c6e8814
@svvald svvald linked a pull request Dec 25, 2024 that will close this issue
Backmerge: #6185 – Make SGroups expandable while placed within a chain #6218
Merged
9 tasks
@Zhirnoff
Copy link
Collaborator Author

Tested. Bug fixed.
2024-12-26_10h47_46
2024-12-26_10h49_20

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.28.0-rc.4]
Indigo version
[Version 1.27.0-rc.2]

svvald added a commit that referenced this issue Dec 30, 2024
@svvald
Backmerge: #6185 – Make SGroups expandable while placed within a chain
8291f30
svvald added a commit that referenced this issue Dec 30, 2024
@svvald
Backmerge: #6185 – Make SGroups expandable while placed within a chain
b0a914f
svvald added a commit that referenced this issue Dec 30, 2024
@svvald
Backmerge: #6185 – Make SGroups expandable while placed within a chain (
abc694a 
#6218)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svvald svvald

Labels
bug Export to SDF Bucket: Bugs related to Export to SDF Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: High Severity: High High level visibility to the user User's Feedback
Projects
None yet
Milestone
Ketcher 2.28.0-rc.4
3 participants
@svvald @AlexeyGirin @Zhirnoff