Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find 'TemporarilyAddMemory' #2

Open
201419 opened this issue Jun 26, 2019 · 2 comments
Open

Cannot find 'TemporarilyAddMemory' #2

201419 opened this issue Jun 26, 2019 · 2 comments

Comments

@201419
Copy link

201419 commented Jun 26, 2019

Hi, your work is so great!

There is a small problem here. I can't find TemporarilyAddMemory this file, but you used from optimizers.TemporarilyAddMemory import TemporarilyAddMemory in the 22nd line of the main.py file.

https://github.com/epfml/error-feedback-SGD/blob/master/main.py#L22

Have you forgotten to upload this file ?

@201419 201419 closed this as completed Jun 26, 2019
@Saipraneet
Copy link
Member

Thanks for pointing this out! We indeed forgot to clean up our code properly. For now, just commenting out this line should fix the issue. Let me know if it works :)

@Saipraneet Saipraneet reopened this Jun 26, 2019
@201419
Copy link
Author

201419 commented Jun 29, 2019

You're welcome. I found class TemporarilyAddMemory in the /utils/convex_opt.py file.

You are right and I can fix it by commenting out this line.

Still have to say, your work is so great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants