ioc: fix dbLoadGroups command. #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling GroupConfigProcessor().loadConfigFiles() reads and clears config.groupConfigFiles, and loads the JSON files before iocInit. When loadConfigFiles() is called again from an init-hook, config.groupConfigFiles is empty, and no JSON files are actually read, so no groups in those files are loaded. This change removes error messages at the point where dbLoadGroup is called; errors are now displayed only during iocInit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling GroupConfigProcessor().loadConfigFiles() reads and clears config.groupConfigFiles, and loads the JSON files before iocInit. When loadConfigFiles() is called again from an init-hook, config.groupConfigFiles is empty, and no JSON files are actually read, so no groups in those files are loaded.
This change removes error messages at the point where dbLoadGroup is called; errors are now displayed only during iocInit.
Fixes #88
I would like to add tests before merging this.Done!I think I mostly understood what caused this problem, but I couldn't find where
config.groupMapis cleared before/duringiocInit, so I didn't understand whyloadConfigFiles()beforeiocInitwas an issue.I'm assuming
groupConfigFilesis cleared bystd::move(this seems to be a correct assumption), but if there's some spot that simply clears the wholeconfig, it might simply be cleared along withgroupMap.