Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.sh missing dependency checks #32

Open
gilesknap opened this issue Feb 4, 2024 · 2 comments
Open

install.sh missing dependency checks #32

gilesknap opened this issue Feb 4, 2024 · 2 comments

Comments

@gilesknap
Copy link
Member

install.sh is supposed to be the recipe for building a support module in the container environment.

However it is up to the Dockerfile to build dependencies before calling install.sh for a given module. This is fine, except that the install.sh should be able to give the developer information on the dependencies and check that they have been supplied.

I suggest:

ibek support check-dependencies Asyn busy ADCore

for example. How to check? We could just do it off of macros in global configure RELEASE or we could get more sophisticated and check that the module has actually been built. @coretl @GDYendell looking for suggestions of how to do this in a clean fashion.

This helps avoid unpicking build errors due to missing dependencies.

@GDYendell
Copy link
Member

Would checking for /epics/support/<module> be sufficient?

@gilesknap
Copy link
Member Author

Tom and I discussed this morning.
The checks will be:-

  • does the UCASE version of the module name exist in /epics/support/configure/RELEASE
  • does the folder with the module name exist in /epics/support and does it contain at least one of db dbd or lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants