Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up contact_matrix function #131

Open
sbfnk opened this issue Sep 17, 2024 · 1 comment · May be fixed by #156
Open

Split up contact_matrix function #131

sbfnk opened this issue Sep 17, 2024 · 1 comment · May be fixed by #156
Milestone

Comments

@sbfnk
Copy link
Collaborator

sbfnk commented Sep 17, 2024

It's too long and hard to parse - atomised bits should be split off into separate functions.

@sbfnk
Copy link
Collaborator Author

sbfnk commented Nov 18, 2024

One thing that could/should be done as part of this is to move some of the data (pre-)processing into other functions.

E.g. it would be better along the lines of:

polymod |>
  split_age_into_groups(c(0, 5, 10, 15) |>
  sample_missing("age.group") |>
  contact_matrix()

rather than doing this inside contact_matrix()

@sbfnk sbfnk linked a pull request Nov 18, 2024 that will close this issue
@sbfnk sbfnk linked a pull request Nov 18, 2024 that will close this issue
@sbfnk sbfnk added this to the 1.0.0 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant