Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace reComBat with limma::removeBatchEffect #20

Open
sreichl opened this issue Nov 15, 2024 · 0 comments
Open

replace reComBat with limma::removeBatchEffect #20

sreichl opened this issue Nov 15, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@sreichl
Copy link
Collaborator

sreichl commented Nov 15, 2024

Consider replacing reComBat with limma::removeBatchEffect
https://rdrr.io/bioc/limma/man/removeBatchEffect.html

pro

con

  • supports only two factors (batch1 and batch2)

Considerations

  • required design matrix is tricky, unsure if I implement a formula or just "tell me the columns you care about as list" (and add them together into a formula internally).
  • could also lead to a change in filter by expression step to support formulas or multiple columns?

decision: replace reComBat w/ limma:removeBatchEffect

@sreichl sreichl self-assigned this Nov 15, 2024
@sreichl sreichl added the enhancement New feature or request label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant