-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #477: Add analytical likelihoods to R functionality #540
Conversation
Saving this to address with a more well-formed solution in #476. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another quite big PR with some masking linting and formatting fixes but all looks good to me and test coverage of the changes is highly.
Going to resolve the pre-commit issues which are due to Air and styler having a conflict in its own PR.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #540 +/- ##
==========================================
+ Coverage 94.38% 95.59% +1.20%
==========================================
Files 17 17
Lines 837 998 +161
==========================================
+ Hits 790 954 +164
+ Misses 47 44 -3 ☔ View full report in Codecov by Sentry. |
Description
This PR closes #477. It also closes #538 and #526. It is a draft and so not suitable for review/merging.
This PR:
cens
that was causing an issue for some likelihood callsprimarycensored
supportsprimarycensored
. This is unfortunate but I can't find a workaround.I have checked the support for
priorsense
andloo
. Without the analytical likelihoods the code in this PR enables these functions to run but with 10 coresloo
still takes 5 minutes andpriorsense
runs for longer than I wanted to wait and see. With the analytical solutions enabled (this also side steps #476 hence the big speed up)loo
takes a few seconds andpriorsense
takes less than 30 seconds for me (the code in the FAQ vignette).Work to do:
Checklist