Issue 3: Not using DT. #4
Conversation
|
By the way, I don't have permission to commit directly to this repo... so I can't add a reviewer either or make a branch in the main repo... @seabbs |
|
It looks like this is failing because we have no tests set up...? |
Very annoying. I added you as an admin |
| @@ -16,12 +15,10 @@ sample_model <- function(model, data, scenario = data.table::data.table(id = 1), | |||
| fit <- safe_fit_model(model, data, ...) | |||
|
|
|||
| if (!is.null(fit$error)) { | |||
| out <- out |> | |||
| DT(, error := list(fit$error[[1]])) | |||
| out[, error := list(fit$error[[1]])] | |||
There was a problem hiding this comment.
an annoying side effect of linting. Need to add error as a global var in utils to get rid of this flag.
There was a problem hiding this comment.
or we can update the linter to ignore global var checks (but then Rmd check will still flag this anyway)
There was a problem hiding this comment.
alternatively the env features we use elsewhere may help here?
There was a problem hiding this comment.
Nice ❤️! The linting flags are from global variables throwing problems and can be dealt with in another issue I think.
We might also want an issue for making some of the data.table a bit cleaner without pipes as rather than doing each operation on a single line we might now want to start doing dt[, :=(one_thing, two_thing, three_thing)].
Looking at the check now to see what the problem is.
| @@ -16,12 +15,10 @@ sample_model <- function(model, data, scenario = data.table::data.table(id = 1), | |||
| fit <- safe_fit_model(model, data, ...) | |||
|
|
|||
| if (!is.null(fit$error)) { | |||
| out <- out |> | |||
| DT(, error := list(fit$error[[1]])) | |||
| out[, error := list(fit$error[[1]])] | |||
There was a problem hiding this comment.
or we can update the linter to ignore global var checks (but then Rmd check will still flag this anyway)
| data.table::DT(, | ||
| sd := exp(meanlog + (1 / 2) * sdlog ^ 2) * sqrt(exp(sdlog ^ 2) - 1) | ||
| ) | ||
| nat_dt <- data.table::copy(dt) |
There was a problem hiding this comment.
in the original (i.e. above) we aren't making a copy but I think its fine either way (though add might imply no copy?)
| draws <- data.table::copy(draws) | ||
| draws[, mean := mean - runif(.N, min = 0, max = 1)] | ||
| draws[, meanlog := log(mean^2 / sqrt(sd^2 + mean^2))] | ||
| draw[, sdlog := sqrt(log(1 + (sd^2 / mean^2)))] |
There was a problem hiding this comment.
| draw[, sdlog := sqrt(log(1 + (sd^2 / mean^2)))] | |
| draws[, sdlog := sqrt(log(1 + (sd^2 / mean^2)))] |
| @@ -16,12 +15,10 @@ sample_model <- function(model, data, scenario = data.table::data.table(id = 1), | |||
| fit <- safe_fit_model(model, data, ...) | |||
|
|
|||
| if (!is.null(fit$error)) { | |||
| out <- out |> | |||
| DT(, error := list(fit$error[[1]])) | |||
| out[, error := list(fit$error[[1]])] | |||
There was a problem hiding this comment.
alternatively the env features we use elsewhere may help here?
Yes exactly. I have only partially added all the package infra this needs unfortunately. |
Former-commit-id: 26eb0ceec6e44cce1a0a8243482f174e64afcb24 [formerly cfa856cceeb0f22d605a3130e90096d9853ed6b3] Former-commit-id: b27ad83c48ed189f3829cac561cd29b4f96dfeda
Former-commit-id: 1a625cd Former-commit-id: 68d2d0232db3dc09efaa429d5641b32b4aee1f2f
Former-commit-id: 1a625cd Former-commit-id: 68d2d0232db3dc09efaa429d5641b32b4aee1f2f
Former-commit-id: 1a625cd Former-commit-id: 68d2d0232db3dc09efaa429d5641b32b4aee1f2f
Former-commit-id: 26eb0ceec6e44cce1a0a8243482f174e64afcb24 [formerly cfa856cceeb0f22d605a3130e90096d9853ed6b3] Former-commit-id: b27ad83c48ed189f3829cac561cd29b4f96dfeda
Former-commit-id: 26eb0ceec6e44cce1a0a8243482f174e64afcb24 [formerly cfa856cceeb0f22d605a3130e90096d9853ed6b3] Former-commit-id: b27ad83c48ed189f3829cac561cd29b4f96dfeda Former-commit-id: 5859e28
Description
This PR closes #3 .
Checklist