-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 40: Add example test data #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine and a reasonable thing to do but note that CRAN can get funny about including data just for examples. As flagged in the issue we might want to consider the alternative approach epinowcast
users or provide some pushback as to why we should take this approach
I've made the test data internal. As for the seed issue, I've rerun it two times and the results are the same, so seems fine. |
I'm pretty indifferent about it being in |
Have reverted back to data being a part of the package, and added documentation. Ready for review @seabbs. |
From https://r-pkgs.org/data.html:
Not perfect fit but arguably the test data could be helpful to a user.
The test data are for own use as a developer. It's not "internal data that functions need" though.
No.
No.
No. |
@athowes and I had a f2f chat and concluded we should use simulated data in the tests via |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good. A few minor comments
Have fixed these comments I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to go now except the minor linting issues
Failing lint due to "Variable and function names should not be longer than 30 characters."
|
* Add example test data generation in data-raw and as .rda * Make the test data internal * Delete PNAS data (assume copied here from another package) * Revert back to non-internal data * Add data documentation * Move simulated data generation from data-raw to tests/testthat * Add PNAS ebola data in raw xlsx format with script for saving it to rda in data * Remove simulated data from data/ * Clean the ebola column names * Document ebola data * Add readxl and janitor to Suggests * Add newline to end of file * Add ask to cite and spacing change * Change name to "ebola_outbreak_sierra_leone" and document roxygen2 * Fix linter issues * Rename to sierra_leone_ebola_outbreak_data * Use shorter ebola data name, and change code style Former-commit-id: 402162a536b79273485492ed4af4ed3c5b760ed2 [formerly 3528376db71b7640f2f7976b5cc06855c792d1d9] Former-commit-id: 57355982266f61ca1f7f81ed8b3a6f3c762a0477
* Add example test data generation in data-raw and as .rda * Make the test data internal * Delete PNAS data (assume copied here from another package) * Revert back to non-internal data * Add data documentation * Move simulated data generation from data-raw to tests/testthat * Add PNAS ebola data in raw xlsx format with script for saving it to rda in data * Remove simulated data from data/ * Clean the ebola column names * Document ebola data * Add readxl and janitor to Suggests * Add newline to end of file * Add ask to cite and spacing change * Change name to "ebola_outbreak_sierra_leone" and document roxygen2 * Fix linter issues * Rename to sierra_leone_ebola_outbreak_data * Use shorter ebola data name, and change code style Former-commit-id: d140527 Former-commit-id: 4ec821ababa950c635bdc96ad43a3dc1def7f70a
* Add example test data generation in data-raw and as .rda * Make the test data internal * Delete PNAS data (assume copied here from another package) * Revert back to non-internal data * Add data documentation * Move simulated data generation from data-raw to tests/testthat * Add PNAS ebola data in raw xlsx format with script for saving it to rda in data * Remove simulated data from data/ * Clean the ebola column names * Document ebola data * Add readxl and janitor to Suggests * Add newline to end of file * Add ask to cite and spacing change * Change name to "ebola_outbreak_sierra_leone" and document roxygen2 * Fix linter issues * Rename to sierra_leone_ebola_outbreak_data * Use shorter ebola data name, and change code style Former-commit-id: d140527 Former-commit-id: 4ec821ababa950c635bdc96ad43a3dc1def7f70a
* Add example test data generation in data-raw and as .rda * Make the test data internal * Delete PNAS data (assume copied here from another package) * Revert back to non-internal data * Add data documentation * Move simulated data generation from data-raw to tests/testthat * Add PNAS ebola data in raw xlsx format with script for saving it to rda in data * Remove simulated data from data/ * Clean the ebola column names * Document ebola data * Add readxl and janitor to Suggests * Add newline to end of file * Add ask to cite and spacing change * Change name to "ebola_outbreak_sierra_leone" and document roxygen2 * Fix linter issues * Rename to sierra_leone_ebola_outbreak_data * Use shorter ebola data name, and change code style Former-commit-id: d140527 Former-commit-id: 4ec821ababa950c635bdc96ad43a3dc1def7f70a
* Add example test data generation in data-raw and as .rda * Make the test data internal * Delete PNAS data (assume copied here from another package) * Revert back to non-internal data * Add data documentation * Move simulated data generation from data-raw to tests/testthat * Add PNAS ebola data in raw xlsx format with script for saving it to rda in data * Remove simulated data from data/ * Clean the ebola column names * Document ebola data * Add readxl and janitor to Suggests * Add newline to end of file * Add ask to cite and spacing change * Change name to "ebola_outbreak_sierra_leone" and document roxygen2 * Fix linter issues * Rename to sierra_leone_ebola_outbreak_data * Use shorter ebola data name, and change code style Former-commit-id: 402162a536b79273485492ed4af4ed3c5b760ed2 [formerly 3528376db71b7640f2f7976b5cc06855c792d1d9] Former-commit-id: 57355982266f61ca1f7f81ed8b3a6f3c762a0477
* Add example test data generation in data-raw and as .rda * Make the test data internal * Delete PNAS data (assume copied here from another package) * Revert back to non-internal data * Add data documentation * Move simulated data generation from data-raw to tests/testthat * Add PNAS ebola data in raw xlsx format with script for saving it to rda in data * Remove simulated data from data/ * Clean the ebola column names * Document ebola data * Add readxl and janitor to Suggests * Add newline to end of file * Add ask to cite and spacing change * Change name to "ebola_outbreak_sierra_leone" and document roxygen2 * Fix linter issues * Rename to sierra_leone_ebola_outbreak_data * Use shorter ebola data name, and change code style Former-commit-id: 402162a536b79273485492ed4af4ed3c5b760ed2 [formerly 3528376db71b7640f2f7976b5cc06855c792d1d9] Former-commit-id: 57355982266f61ca1f7f81ed8b3a6f3c762a0477 Former-commit-id: 65806aa
* Add example test data generation in data-raw and as .rda * Make the test data internal * Delete PNAS data (assume copied here from another package) * Revert back to non-internal data * Add data documentation * Move simulated data generation from data-raw to tests/testthat * Add PNAS ebola data in raw xlsx format with script for saving it to rda in data * Remove simulated data from data/ * Clean the ebola column names * Document ebola data * Add readxl and janitor to Suggests * Add newline to end of file * Add ask to cite and spacing change * Change name to "ebola_outbreak_sierra_leone" and document roxygen2 * Fix linter issues * Rename to sierra_leone_ebola_outbreak_data * Use shorter ebola data name, and change code style Former-commit-id: d140527 Former-commit-id: 4ec821ababa950c635bdc96ad43a3dc1def7f70a Former-commit-id: 193fd3c60e41e5a4c319d604b4cf71f2cb16a25e [formerly e8b98fe] Former-commit-id: ae71e652bc5e2f008ccf024c951af8e5d91e98a9
* Add example test data generation in data-raw and as .rda * Make the test data internal * Delete PNAS data (assume copied here from another package) * Revert back to non-internal data * Add data documentation * Move simulated data generation from data-raw to tests/testthat * Add PNAS ebola data in raw xlsx format with script for saving it to rda in data * Remove simulated data from data/ * Clean the ebola column names * Document ebola data * Add readxl and janitor to Suggests * Add newline to end of file * Add ask to cite and spacing change * Change name to "ebola_outbreak_sierra_leone" and document roxygen2 * Fix linter issues * Rename to sierra_leone_ebola_outbreak_data * Use shorter ebola data name, and change code style Former-commit-id: d140527 Former-commit-id: 4ec821ababa950c635bdc96ad43a3dc1def7f70a Former-commit-id: 193fd3c60e41e5a4c319d604b4cf71f2cb16a25e [formerly e8b98fe] Former-commit-id: ae71e652bc5e2f008ccf024c951af8e5d91e98a9
Description
This PR closes #40.
I have some remaining uncertainty about:
set.seed
work as intended? What about thatsimulate_gillespie()
has aset.seed
argument?Checklist