Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-page Editing or InContext editing is not happening in the CMS page #90

Open
pnittala opened this issue Jan 24, 2025 · 5 comments
Open

Comments

@pnittala
Copy link

I have created this issue #86. Having seen that you have updated it as completed, I have taken the recent version (848609ceb509d5b01874a6ddb338bba781c7d82a) and deployed it.

Vercel deploy was successful but I See page not found on the home page. When I visit the /en page the site shows up fine.

In the SAAS CMS, Visual Builder is identifying the components, however the on-page editing or in-context editing is not happening on the visual page. Anything I update in the text fields is getting reflected on the page though. Is this the expected behavior? For example shown in red circle the "Heading" field if updated there gets reflected on the page, but cannot edit it on-page editing or in-context.

Image

I followed the steps mentioned in this article https://github.com/episerver/cms-saas-vercel-demo/blob/main/docs/editing.md just to be sure. Is this expected behavior? Should I be able to do on-page editing?

@MineshS
Copy link

MineshS commented Jan 24, 2025

Regarding the language issue you can set your locacle to 'en' for the hostname, this is in manage applications in settings. You will also need to re-run the graph index.

Regarding OPE it seems you are in the Visual Builder View if you change to OPE it should work

@pnittala
Copy link
Author

pnittala commented Jan 24, 2025

@MineshS, thanks for your response. I have set the language to "en" for the hostname in the applications and did rerun of full synchronization graphql job.

Regarding OPE, I do not see the On-Page Editing mode as shown in the image circled in red

Image

In Visual Builder, It doesn't do on-page editing. Not sure if this is the expected behavior.

@MineshS
Copy link

MineshS commented Jan 24, 2025

Correct in Visual Builder View the Old Style On Page Editing view does not work (I don't think) when I last checked their were 3 options OPE, All Properties and Visual Builder for Standard Pages not sure if anything has changed in the last week

@pnittala
Copy link
Author

Yes, I remember seeing OPE, All Properites, Visual Builder options in the circled red area before in this instance. The only changes I did was to install the updated package (https://github.com/episerver/cms-saas-vercel-demo/blob/main/InitialData.episerverdata) and take the new version of source code and deploy.

@JohanPetersson
Copy link

This is expected behavior. There is no "inline editing" in SaaS or the new editing experience since that don't work well cross-domain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants