Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joint estimation of R and k #124

Closed
adamkucharski opened this issue Nov 22, 2022 · 5 comments
Closed

Joint estimation of R and k #124

adamkucharski opened this issue Nov 22, 2022 · 5 comments
Milestone

Comments

@adamkucharski
Copy link
Member

It would be useful to have functionality to jointly estimate R and k using the functions in likelihoods.R. Perhaps as a starting point by using simple profile likelihood methods similar to the ones here (which also includes some chain data for MERS): https://github.com/calthaus/MERS

@sbfnk
Copy link
Contributor

sbfnk commented Jan 12, 2023

In principle this functionality already exists (though maybe needs to be surfaced a bit more) by wrapping chain_ll with a negative binomial and two parameters into an estimator / MCMC / etc.

@jamesmbaazam
Copy link
Member

jamesmbaazam commented Jan 24, 2023

@adamkucharski I believe this issue will be solved by quickfit and should be closed??

@adamkucharski
Copy link
Member Author

Reopening as based on current discussions, sounds like would be useful to include as a vignette in epichains. I've got loads of cluster size data kicking around from other work if useful (e.g. MERS, H5N1, H7N9).

More discussion of functionality for estimation (e.g. normal approx, marginal, profile likelihood) is in this issue on quickfit. Also tagging @joshwlambert

@adamkucharski adamkucharski reopened this Dec 12, 2023
@jamesmbaazam
Copy link
Member

Thanks @adamkucharski. Will transfer this issue to {epichains}.

@jamesmbaazam jamesmbaazam transferred this issue from epiforecasts/bpmodels Dec 12, 2023
@jamesmbaazam jamesmbaazam added this to the v0.2.0 milestone Jan 29, 2024
@jamesmbaazam
Copy link
Member

The suggestion to include estimation functionality in {epichains} has been discussed a few times and deemed out of the scope of this package as it might introduce heavy dependencies and potentially become a maintenance burden. It might also require being opinionated about which frameworks to use. There has been some discussion of the pros and cons of existing options in https://github.com/orgs/epiverse-trace/discussions/185 and will be useful to anyone interested in pursuing this further.

The vignette suggested here will be addressed when epiverse-trace/howto#57 is merged into the how-to guides. Users who are interested in this should explore the options provided there.

In light of all this, I am closing this issue.

@github-project-automation github-project-automation bot moved this from Todo to Done in epichains-v0.2.0 May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants