fix(profile): allow user to have no posts/threads when querying posts/threads by username

Author: akinsey

lib/epochtalk_server_web/controllers/post.ex

@@ -387,8 +387,7 @@ defmodule EpochtalkServerWeb.Controllers.Post do
              per_page: limit,
              desc: desc
            ),
-         count <- Profile.post_count_by_username(username),
-         {:has_posts, true} <- {:has_posts, posts != []} do
+         count <- Profile.post_count_by_username(username) do
       render(conn, :by_username, %{
         posts: posts,
         user: user,
@@ -400,9 +399,6 @@ defmodule EpochtalkServerWeb.Controllers.Post do
         desc: desc
       })
     else
-      {:has_posts, false} ->
-        ErrorHelpers.render_json_error(conn, 404, "Error, requested posts not found")
-
       {:view_deleted_users, false} ->
         ErrorHelpers.render_json_error(conn, 400, "Account not found")
 

lib/epochtalk_server_web/controllers/thread.ex

@@ -255,8 +255,7 @@ defmodule EpochtalkServerWeb.Controllers.Thread do
            Thread.page_by_username(username, priority, page,
              per_page: limit + 1,
              desc: desc
-           ),
-         {:has_threads, true} <- {:has_threads, threads != []} do
+           ) do
       render(conn, :by_username, %{
         threads: threads,
         user: user,
@@ -267,9 +266,6 @@ defmodule EpochtalkServerWeb.Controllers.Thread do
         page: page
       })
     else
-      {:has_threads, false} ->
-        ErrorHelpers.render_json_error(conn, 404, "Error, requested threads not found")
-
       {:view_deleted_users, false} ->
         ErrorHelpers.render_json_error(conn, 400, "Account not found")