Merge pull request #51 from epochtalk/testing

Testing

Author: akinsey

test/epochtalk_server_web/controllers/thread_test.exs

@@ -46,7 +46,7 @@ defmodule Test.EpochtalkServerWeb.Controllers.Thread do
     test "given an id for existing board, gets threads", %{
       conn: conn,
       board: board,
-      threads: created_threads
+      threads: factory_threads
     } do
       response =
         conn
@@ -56,10 +56,9 @@ defmodule Test.EpochtalkServerWeb.Controllers.Thread do
       assert Map.has_key?(response, "normal") == true
       assert Map.has_key?(response, "sticky") == true
 
+      # check thread keys
       normal_threads = response["normal"]
       first_thread = normal_threads |> List.first()
-      first_created_thread = created_threads |> List.first()
-      first_created_thread_attributes = first_created_thread.attributes
       assert Map.has_key?(first_thread, "created_at") == true
       assert Map.has_key?(first_thread, "last_post_avatar") == true
       assert Map.has_key?(first_thread, "last_post_created_at") == true
@@ -77,15 +76,22 @@ defmodule Test.EpochtalkServerWeb.Controllers.Thread do
       assert Map.has_key?(first_thread, "user") == true
       assert Map.has_key?(first_thread, "view_count") == true
 
-      assert Map.get(first_thread, "id") == first_created_thread.post.thread.id
-      assert Map.get(first_thread, "locked") == Map.get(first_created_thread_attributes, "locked")
+      # compare to factory results
+      factory_threads = factory_threads |> Enum.sort(&(&1.post.thread.id < &2.post.thread.id))
 
-      assert Map.get(first_thread, "moderated") ==
-               Map.get(first_created_thread_attributes, "moderated")
+      Enum.zip(normal_threads, factory_threads)
+      |> Enum.each(fn {normal_thread, factory_thread} ->
+        factory_thread_attributes = factory_thread.attributes
+        assert Map.get(normal_thread, "id") == factory_thread.post.thread.id
+        assert Map.get(normal_thread, "locked") == Map.get(factory_thread_attributes, "locked")
 
-      assert Map.get(first_thread, "slug") == Map.get(first_created_thread_attributes, "slug")
-      assert Map.get(first_thread, "sticky") == Map.get(first_created_thread_attributes, "sticky")
-      assert Map.get(first_thread, "title") == Map.get(first_created_thread_attributes, "title")
+        assert Map.get(normal_thread, "moderated") ==
+                 Map.get(normal_thread, "moderated")
+
+        assert Map.get(normal_thread, "slug") == Map.get(factory_thread_attributes, "slug")
+        assert Map.get(normal_thread, "sticky") == Map.get(factory_thread_attributes, "sticky")
+        assert Map.get(normal_thread, "title") == Map.get(factory_thread_attributes, "title")
+      end)
     end
 
     test "given an id for board above unauthenticated user priority, does not get threads", %{