From 84a5e9640812f2b6411db0ca9b2af3265f08a46e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sebastian=20H=C3=B6rl?= <hoerl.sebastian@gmail.com>
Date: Mon, 7 Oct 2024 18:52:32 +0200
Subject: [PATCH] avoid circular dependency for predictor

---
 .../estimators/IDFPtUtilityEstimator.java          | 14 ++++++++++----
 .../utilities/predictors/IDFPtPredictor.java       | 12 +++---------
 .../utilities/variables/IDFPtVariables.java        |  4 +---
 3 files changed, 14 insertions(+), 16 deletions(-)

diff --git a/ile_de_france/src/main/java/org/eqasim/ile_de_france/mode_choice/utilities/estimators/IDFPtUtilityEstimator.java b/ile_de_france/src/main/java/org/eqasim/ile_de_france/mode_choice/utilities/estimators/IDFPtUtilityEstimator.java
index b79c8859b..39bdaee0f 100644
--- a/ile_de_france/src/main/java/org/eqasim/ile_de_france/mode_choice/utilities/estimators/IDFPtUtilityEstimator.java
+++ b/ile_de_france/src/main/java/org/eqasim/ile_de_france/mode_choice/utilities/estimators/IDFPtUtilityEstimator.java
@@ -2,6 +2,7 @@
 
 import java.util.List;
 
+import org.eqasim.core.simulation.mode_choice.cost.CostModel;
 import org.eqasim.core.simulation.mode_choice.utilities.UtilityEstimator;
 import org.eqasim.core.simulation.mode_choice.utilities.estimators.EstimatorUtils;
 import org.eqasim.ile_de_france.mode_choice.parameters.IDFModeParameters;
@@ -14,18 +15,21 @@
 import org.matsim.contribs.discrete_mode_choice.model.DiscreteModeChoiceTrip;
 
 import com.google.inject.Inject;
+import com.google.inject.name.Named;
 
 public class IDFPtUtilityEstimator implements UtilityEstimator {
 	private final IDFModeParameters parameters;
 	private final IDFPersonPredictor personPredictor;
 	private final IDFPtPredictor idfPtPredictor;
+	private final CostModel costModel;
 
 	@Inject
 	public IDFPtUtilityEstimator(IDFModeParameters parameters, IDFPtPredictor idfPtPredictor,
-			IDFPersonPredictor personPredictor) {
+			IDFPersonPredictor personPredictor, @Named("pt") CostModel costModel) {
 		this.personPredictor = personPredictor;
 		this.idfPtPredictor = idfPtPredictor;
 		this.parameters = parameters;
+		this.costModel = costModel;
 	}
 
 	protected double estimateConstantUtility() {
@@ -48,9 +52,9 @@ protected double estimateLineSwitchUtility(IDFPtVariables variables) {
 		return parameters.pt.betaLineSwitch_u * variables.numberOfLineSwitches;
 	}
 
-	protected double estimateMonetaryCostUtility(IDFPtVariables variables) {
+	protected double estimateMonetaryCostUtility(IDFPtVariables variables, double cost_EUR) {
 		return parameters.betaCost_u_MU * EstimatorUtils.interaction(variables.euclideanDistance_km,
-				parameters.referenceEuclideanDistance_km, parameters.lambdaCostEuclideanDistance) * variables.cost_MU;
+				parameters.referenceEuclideanDistance_km, parameters.lambdaCostEuclideanDistance) * cost_EUR;
 	}
 
 	protected double estimateDrivingPermitUtility(IDFPersonVariables variables) {
@@ -66,6 +70,8 @@ public double estimateUtility(Person person, DiscreteModeChoiceTrip trip, List<?
 		IDFPersonVariables personVariables = personPredictor.predictVariables(person, trip, elements);
 		IDFPtVariables ptVariables = idfPtPredictor.predictVariables(person, trip, elements);
 
+		double cost_EUR = costModel.calculateCost_MU(person, trip, elements);
+
 		double utility = 0.0;
 
 		utility += estimateConstantUtility();
@@ -73,7 +79,7 @@ public double estimateUtility(Person person, DiscreteModeChoiceTrip trip, List<?
 		utility += estimateInVehicleTimeUtility(ptVariables);
 		utility += estimateWaitingTimeUtility(ptVariables);
 		utility += estimateLineSwitchUtility(ptVariables);
-		utility += estimateMonetaryCostUtility(ptVariables);
+		utility += estimateMonetaryCostUtility(ptVariables, cost_EUR);
 
 		utility += estimateDrivingPermitUtility(personVariables);
 		utility += estimateOnlyBus(ptVariables);
diff --git a/ile_de_france/src/main/java/org/eqasim/ile_de_france/mode_choice/utilities/predictors/IDFPtPredictor.java b/ile_de_france/src/main/java/org/eqasim/ile_de_france/mode_choice/utilities/predictors/IDFPtPredictor.java
index e2460624f..c34eb34fe 100644
--- a/ile_de_france/src/main/java/org/eqasim/ile_de_france/mode_choice/utilities/predictors/IDFPtPredictor.java
+++ b/ile_de_france/src/main/java/org/eqasim/ile_de_france/mode_choice/utilities/predictors/IDFPtPredictor.java
@@ -18,22 +18,19 @@
 import org.matsim.pt.transitSchedule.api.TransitStopFacility;
 
 import com.google.inject.Inject;
-import com.google.inject.name.Named;
 
 public class IDFPtPredictor extends CachedVariablePredictor<IDFPtVariables> {
 	static public final String PARIS_ATTRIBUTE = "isParis";
 
 	private final TransitSchedule schedule;
-	private final CostModel costModel;
 
 	@Inject
-	public IDFPtPredictor(TransitSchedule schedule, @Named("pt") CostModel costModel) {
+	public IDFPtPredictor(TransitSchedule schedule) {
 		this.schedule = schedule;
-		this.costModel = costModel;
 	}
 
 	protected CostModel getCostModel() {
-		return this.costModel;
+		return null;
 	}
 
 	@Override
@@ -108,9 +105,6 @@ public IDFPtVariables predict(Person person, DiscreteModeChoiceTrip trip, List<?
 
 		int numberOfLineSwitches = Math.max(0, numberOfVehicularTrips - 1);
 
-		// Calculate cost
-		double cost_CHF = costModel.calculateCost_MU(person, trip, elements);
-
 		double euclideanDistance_km = PredictorUtils.calculateEuclideanDistance_km(trip);
 
 		boolean isOnlyBus = busCount > 0 && subwayCount == 0 && otherCount == 0;
@@ -129,6 +123,6 @@ public IDFPtVariables predict(Person person, DiscreteModeChoiceTrip trip, List<?
 		}
 
 		return new IDFPtVariables(inVehicleTime_min, waitingTime_min, accessEgressTime_min, numberOfLineSwitches,
-				cost_CHF, euclideanDistance_km, isOnlyBus, hasOnlySubwayAndBus, isWithinParis);
+				euclideanDistance_km, isOnlyBus, hasOnlySubwayAndBus, isWithinParis);
 	}
 }
\ No newline at end of file
diff --git a/ile_de_france/src/main/java/org/eqasim/ile_de_france/mode_choice/utilities/variables/IDFPtVariables.java b/ile_de_france/src/main/java/org/eqasim/ile_de_france/mode_choice/utilities/variables/IDFPtVariables.java
index 8217773c3..0a7ae3447 100644
--- a/ile_de_france/src/main/java/org/eqasim/ile_de_france/mode_choice/utilities/variables/IDFPtVariables.java
+++ b/ile_de_france/src/main/java/org/eqasim/ile_de_france/mode_choice/utilities/variables/IDFPtVariables.java
@@ -7,7 +7,6 @@ public class IDFPtVariables implements BaseVariables {
 	public final double waitingTime_min;
 	public final double accessEgressTime_min;
 	public final int numberOfLineSwitches;
-	public final double cost_MU;
 	public final double euclideanDistance_km;
 
 	public final boolean isOnlyBus;
@@ -15,13 +14,12 @@ public class IDFPtVariables implements BaseVariables {
 	public final boolean isWithinParis;
 
 	public IDFPtVariables(double inVehicleTime_min, double waitingTime_min, double accessEgressTime_min,
-			int numberOfLineSwitches, double cost_MU, double euclideanDistance_km, boolean isOnlyBus,
+			int numberOfLineSwitches, double euclideanDistance_km, boolean isOnlyBus,
 			boolean hasOnlySubwayAndBus, boolean isWithinParis) {
 		this.inVehicleTime_min = inVehicleTime_min;
 		this.waitingTime_min = waitingTime_min;
 		this.accessEgressTime_min = accessEgressTime_min;
 		this.numberOfLineSwitches = numberOfLineSwitches;
-		this.cost_MU = cost_MU;
 		this.euclideanDistance_km = euclideanDistance_km;
 
 		this.isOnlyBus = isOnlyBus;