Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PendingData to the Storage crate #2038

Open
Mirko-von-Leipzig opened this issue May 28, 2024 · 1 comment
Open

Move PendingData to the Storage crate #2038

Mirko-von-Leipzig opened this issue May 28, 2024 · 1 comment
Milestone
Unify BlockID types

Comments

@Mirko-von-Leipzig
Copy link
Contributor

Move the type across without making any major changes to RPC method's logic. This will include moving the watcher from RPC context to storage's transaction type.

This should hopefully be a minimally invasive change.

Finally, refactor the PendingWatcher::get(tx) accessor to a tx.pending_data() method. This will require cosmetic refactoring for the RPC methods.
@Mirko-von-Leipzig Mirko-von-Leipzig added this to the Unify BlockID types milestone May 28, 2024
@Mirko-von-Leipzig
Copy link
Contributor Author

Previous issue with some other details: #1691

This was referenced May 28, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
pathfinder
Status: No status
Milestone
Unify BlockID types
Development

No branches or pull requests
1 participant
@Mirko-von-Leipzig