Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace storage::BlockId with common::BlockId #2039

Open
Mirko-von-Leipzig opened this issue May 28, 2024 · 0 comments
Open

Replace storage::BlockId with common::BlockId #2039

Mirko-von-Leipzig opened this issue May 28, 2024 · 0 comments

Comments

@Mirko-von-Leipzig
Copy link
Contributor

Should only be done after #2038 and #1738.

This will be quite a painful refactoring, but should result in less code branches within RPC methods.

Be aware that some methods might still require special handling of the pending branch. e.g. pending block headers are a subset of the full block header.

Once completed, the transaction::pending_data method should be made private which will ensure that the work is completed correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant