Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC: remove SerializationForVersion blanket impl for serde #2048

Closed
Mirko-von-Leipzig opened this issue May 30, 2024 · 0 comments · Fixed by #2459
Closed

RPC: remove SerializationForVersion blanket impl for serde #2048

Mirko-von-Leipzig opened this issue May 30, 2024 · 0 comments · Fixed by #2459

Comments

@Mirko-von-Leipzig
Copy link
Contributor

Requires #2047.

To allow for transitioning from serde::Serialize to SerializeForVersion, the latter currently has a blanket implementation for all T: serde::Serialize.

Once the transition is complete, we can and should remove this blanket implementation. This will prove that we no longer rely on serde::Serialization directly.

You may find that this results in compilation errors in some DTO implementations. This will likely be due to missing primitive implementations for our trait. Various string or integer types spring to mind as likely culprits. These should be added explicitly to the serialization impl as demonstrated here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
1 participant