Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adhere new naming conventions #111

Merged
merged 3 commits into from
Aug 1, 2024
Merged

chore: adhere new naming conventions #111

merged 3 commits into from
Aug 1, 2024

Conversation

zeapoz
Copy link
Member

@zeapoz zeapoz commented Jul 30, 2024

The new naming convention is as follows:

  • L1 block number - The Ethereum block height of the published batch.
  • L1 batch number - The number of the ZKSync batch.
  • L2 block number - The legacy number of the ZKSync batch (formerly known as miniblock).

@zeapoz zeapoz requested a review from vbar July 30, 2024 12:05
vbar
vbar reviewed Jul 30, 2024
View reviewed changes
src/processor/snapshot/mod.rs Outdated Show resolved Hide resolved
state-reconstruct-fetcher/src/l1_fetcher.rs Outdated Show resolved Hide resolved
state-reconstruct-fetcher/src/metrics.rs Outdated Show resolved Hide resolved
state-reconstruct-fetcher/src/metrics.rs Outdated Show resolved Hide resolved
vbar
vbar approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@vbar vbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any more problems, but I do recommend testing before merge... :-)

@zeapoz
Copy link
Member Author

zeapoz commented Jul 30, 2024

I don't see any more problems, but I do recommend testing before merge... :-)

Of course, doing some as we speak 😃

@zeapoz zeapoz merged commit db3b3c2 into main Aug 1, 2024
4 checks passed
@zeapoz zeapoz deleted the chore/adhere-new-naming-conventions branch August 1, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbar vbar vbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeapoz @vbar