bug: command --locked false to unlock the server doesn't work, however --locked true to lock the server does work.

[waltribeiro]

What happened?

The --locked false and -l false commands do not work. According to the Docs, a boolean can lock or unlock the server from being updated.

However, only --locked true and -l true seem to work. This is seen in the video below.

How can we reproduce it?

1. Deploy server.
2. Get server ID.
3. Run command metal device update --id <server-id> --locked true to lock the server.
4. Confirm that it is locked on console.equinix.com.

5. Run command metal device update --id <server-id> --locked false to unlock the server.
6. Confirm that it is unlocked on console.equinix.com. However, it is not.

Note

CLI ==version== (metal --version): metal version 0.24.0

Important

video-locked-hb.mp4

[waltribeiro]

Update: logs confirm that the --locked false command is not being sent at all.

[displague]

https://github.com/equinix/metal-cli/blob/main/internal/devices/update.go#L82-L85 will only apply locked changes when the variable is set to true.

The code should look at wether or not the parameter was sent and set locked based on the specified setting. false should not be the default.

I don't see other examples in this project of an optional boolean variable whose value must be explicitly false or true when specified.