Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chakra ui adds cookies prior consent #1444

Closed
padms opened this issue Jan 5, 2023 · 9 comments
Closed

Chakra ui adds cookies prior consent #1444

padms opened this issue Jan 5, 2023 · 9 comments
Assignees

Comments

@padms
Copy link
Contributor

padms commented Jan 5, 2023

chakra-ui-color-mode is added to local storage before consent

More information is available in the attachments in the email from cookie bot

@fernandolucchesi
Copy link
Contributor

Could be as easy as removing the ChrakraProvider, or as complicated as adding chakra to consent

@millianapia
Copy link
Contributor

I rewrote _app so it uses baseprovider instead of the standard chakraprovider, is it any way of verifying this in test if it helped regarding the cookies and accessability issues @fernandolucchesi

@fernandolucchesi
Copy link
Contributor

I rewrote _app so it uses baseprovider instead of the standard chakraprovider, is it any way of verifying this in test if it helped regarding the cookies and accessability issues @fernandolucchesi

@padms can you check for the cookiebot? I am not sure how to test it.

As for the accessibility, problem still exists. Basically the context is creating a chakra-portal that we are not using/has incorrect accessibility props, you can read more on #1415
image

@padms
Copy link
Contributor Author

padms commented Jan 13, 2023

I see cookie in the local storage. image.png

@millianapia
Copy link
Contributor

as baseprovider did not live up to expectations, i will try removing the chakraprovider all-together from the _app file.

@millianapia
Copy link
Contributor

did not get any local cookies when removing the baseprovider, will check in global dev when it is finished building

@millianapia
Copy link
Contributor

@fernandolucchesi @padms could either of you verify the new changes

@padms
Copy link
Contributor Author

padms commented Jan 18, 2023

Could verify that no cookie is added now

@millianapia
Copy link
Contributor

this is a very technical issue so there is no other test to be made than checking if cookie is added which @padms did, it is connected to the #1378 so i will move it to the other column

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants