Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom missions are not read in correctly #1760

Open
andchiind opened this issue Oct 14, 2024 · 2 comments
Open

Custom missions are not read in correctly #1760

andchiind opened this issue Oct 14, 2024 · 2 comments
Assignees
Labels
backend Backend related functionality bug Something isn't working

Comments

@andchiind
Copy link
Contributor

andchiind commented Oct 14, 2024

Describe the bug
When we try to schedule a custom mission the mission loader assumes that all missions are echo missions and tries to fetch the mission from echo using the source ID. This causes an error as the ID is not an integer for custom missions, but rather the hash of the tasks of the mission. The problem can be traced to the "GetMissionById" function in "EchoAndCustomMissionLoader.cs", which is expected to handle echo and custom missions, but which currently always assumes that we are using echo missions.

To Reproduce
There are some example custom missions in Dev. Running these will cause an exception the echo service.

Expected behavior
We currently store custom missions directly in the Source model. When scheduling a mission we can check whether this value is set, and, if so, use the SourceService to read in the mission. As a further improvement, we could add an enum to the Source model which can specify the mission loader to use for that mission.

Screenshots

@andchiind andchiind added backend Backend related functionality bug Something isn't working labels Oct 14, 2024
@andchiind andchiind changed the title Custom mission don't currently work Custom missions are not read in correctly Oct 14, 2024
@tsundvoll
Copy link
Contributor

How can we make sure that both models are up to date (Echo Mission and Custom Mission)?

@andchiind
Copy link
Contributor Author

How can we make sure that both models are up to date (Echo Mission and Custom Mission)?

I am not sure I understand this question. We do not need to edit any models to solve this issue.

@mrica-equinor mrica-equinor self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants