Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only display "recharging" in the frontend if we know the robot is docked #1877

Open
andchiind opened this issue Dec 12, 2024 · 1 comment
Open
Labels
backend Backend related functionality frontend Frontend related functionality improvement Improvement to existing functionality

Comments

@andchiind
Copy link
Contributor

Describe the improvement you would like to see
Currently we assume the robot is recharging based on actions performed in Flotilla. Instead, we should display that the battery is recharging only if we receive this information from ISAR, and we should also only show that it is in the "recharging" state (ie. that we won't run missions until we are nearly fully charged), if we both have the flotilla recharging state and the robot reports it is in the docking station. This issue is therefore dependent on this ISAR issue: equinor/isar#680

How will this change existing functionality?
It will prevent assumptions regarding ISAR state in Flotilla, by more directly replying on information from ISAR.

How will this improvement affect the current Threat Model?
N/A

@andchiind andchiind added backend Backend related functionality frontend Frontend related functionality improvement Improvement to existing functionality labels Dec 12, 2024
@andchiind andchiind changed the title Only display "recharging" in the frontend if we know the robot is recharging Only display "recharging" in the frontend if we know the robot is docked Dec 12, 2024
@Eddasol
Copy link
Contributor

Eddasol commented Dec 13, 2024

Related to #1757 and #1873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality frontend Frontend related functionality improvement Improvement to existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants