You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I think it would be a nice idea to add the viewBox attribute to the generated svg file because the tag is missing viewBox, height and width attributes (at least for the World map, which I believe could be the most used). A use case example is when rendering a HTML file with WeasyPrint to PDF that contains a svg from this package it shows blank, but modifying _to_svg function to include an arbitrary viewBox = "0 0 x y" it shows properly.
Maybe you could detect the dimensions of the base svg by checking its properties and then set up a default viewBox and/or default height and width attributes.
Btw, congrats for the amazing repo, it works pretty cool :)
The text was updated successfully, but these errors were encountered:
Hi, I think it would be a nice idea to add the
viewBox
attribute to the generated svg file because the tag is missingviewBox
,height
andwidth
attributes (at least for the World map, which I believe could be the most used). A use case example is when rendering a HTML file with WeasyPrint to PDF that contains a svg from this package it shows blank, but modifying_to_svg
function to include an arbitraryviewBox = "0 0 x y"
it shows properly.Maybe you could detect the dimensions of the base svg by checking its properties and then set up a default viewBox and/or default
height
andwidth
attributes.Btw, congrats for the amazing repo, it works pretty cool :)
The text was updated successfully, but these errors were encountered: