You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be useful for using BoundedVec in sigma-rust. Also, I was wondering, what are your thoughts on adding a try_push function to BoundedVec? It'd make it a bit easier to use, it could return an Option or Result if there's no more room in the vector.
This will be useful for using BoundedVec in sigma-rust. Also, I was wondering, what are your thoughts on adding a try_push function to BoundedVec? It'd make it a bit easier to use, it could return an Option or Result if there's no more room in the vector.
Excellent question! It deserves a separate issue - #9
Error: Unable to create clippy annotations! Reason: HttpError: Resource not accessible by integration
Warning: It seems that this Action is executed from the forked repository.
Warning: GitHub Actions are not allowed to create Check annotations, when executed for a forked repos. See actions-rs/clippy-check#2 for details.
Running cargo clippy on my system displays no lints.
Error: Unable to create clippy annotations! Reason: HttpError: Resource not accessible by integration
Warning: It seems that this Action is executed from the forked repository.
Warning: GitHub Actions are not allowed to create Check annotations, when executed for a forked repos. See actions-rs/clippy-check#2 for details.
Running cargo clippy on my system displays no lints.
That's a warning that it's unable to create annotations in PR for clippy warnings. However, I don't understand why clippy sees serde import as unused. I'm merging it. :)
@SethDusek Well, it turned out clippy was on to something here. :) With enabled serde feature, build fails on T bounds missing serde traits. I've tried to fix it with no luck. I reverted the changes and made a branch PR for further experiments - #10 with some thoughts on how it could be implemented. Feel free to take over it if you are interested.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be useful for using BoundedVec in sigma-rust. Also, I was wondering, what are your thoughts on adding a try_push function to BoundedVec? It'd make it a bit easier to use, it could return an Option or Result if there's no more room in the vector.