Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not wallet-rescan blockchain from height 0 after wallet initialization #1722

Open
kushti opened this issue May 29, 2022 · 3 comments · May be fixed by #1723
Open

Do not wallet-rescan blockchain from height 0 after wallet initialization #1722

kushti opened this issue May 29, 2022 · 3 comments · May be fixed by #1723
Assignees

Comments

@kushti
Copy link
Member

kushti commented May 29, 2022

Currently, the node wallet is re-scanning the blockchain after wallet initialization, and that does not make much sense. Better to avoid rescan after init.

@pragmaxim
Copy link
Collaborator

@kushti I don't understand, wallet is empty after initialization and we need to scan the blockchain to compute its state.

@kushti
Copy link
Member Author

kushti commented May 30, 2022

@pragmaxim wallet initialized with a new secret key (generated from cryptographically strong randomness), thus blockchain does not contain anything related to the new wallet, unlike wallet restoration from (possibly, previously used) mnemonic

@pragmaxim pragmaxim linked a pull request May 30, 2022 that will close this issue
@scalahub
Copy link
Collaborator

scalahub commented Jun 3, 2022

Yes, also one feature to add if possible:

  • Manually add UTXOs to wallet instead of scanning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants