Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout/TrailingWhitespace on every single line #54

Open
brendonrapp opened this issue Nov 9, 2020 · 6 comments · May be fixed by #59
Open

Layout/TrailingWhitespace on every single line #54

brendonrapp opened this issue Nov 9, 2020 · 6 comments · May be fixed by #59
Assignees
@ericqweinstein
Labels
investigation

Comments

@brendonrapp
Copy link

test.html.erb

<div>
  <p>Test ERB file</p>
</div>

Ruumba output:

% ruumba -v                                                                                                                                                                                                                
ruumba 0.1.16

% ruumba test.html.erb                                                                                                                                                                                                     
Inspecting 1 file
C

Offenses:

test.html.erb:1:1: C: Layout/TrailingWhitespace: Trailing whitespace detected.
test.html.erb:1:2: C: Layout/TrailingEmptyLines: 2 trailing blank lines detected.
test.html.erb:2:1: C: Layout/TrailingWhitespace: Trailing whitespace detected.
test.html.erb:3:1: C: Layout/TrailingWhitespace: Trailing whitespace detected.
@ericqweinstein ericqweinstein self-assigned this Nov 21, 2020
@ericqweinstein
Copy link
Owner

ericqweinstein commented Dec 3, 2020 •
edited
Loading

@brendonrapp Apologies for the delay on this one; I should have a resolution for you over the weekend at the latest.

@ericqweinstein
Copy link
Owner

Reproduced, including for files with interpolated Ruby. @brendonrapp could you confirm your version of Ruby as well?

@ericqweinstein
Copy link
Owner

(My guess is this is a weird interaction between Ruumba and a newer version of RuboCop, but it's always good to have more information.) Actually, if you could share your RuboCop version, that'd be helpful, too.

@ericqweinstein
Copy link
Owner

In the meantime, I'll pin rubocop as > 1.5 in ruumba's Gemfile.

@ericqweinstein
Copy link
Owner

Note that, as per the README, Layout/TrailingEmptyLines is expected (this cop needs to be disabled pending a future PR).

@ericqweinstein
Copy link
Owner

@brendonrapp Apologies for the long delay here. My recommendation is to disable this cop pending a fix (which I'll get to as soon as I have some spare cycles).

@zw963 zw963 mentioned this issue Aug 19, 2021
Open
aclemons added a commit to aclemons/ruumba that referenced this issue Aug 19, 2021
@aclemons
Strip trailing whitespace and newlines when not autocorrecting.
f3590fd 
Since we extract the ruby code from inside the template and run rubocop
on it, keeping the column positions (filling with whitespace) so that we
can find where the code came from when auto correcting, most layout and
style cops don't make much sense with ruumba.

If we are not auto-correcting (which is experimental currently anyway),
we can strip out the trailing spaces and the trailing newlines to avoid
those violations. We will still get indention cop violations etc, but
perhaps this at least gives a slightly better out of the box experience.

Closes ericqweinstein#54
@aclemons aclemons linked a pull request Aug 19, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericqweinstein ericqweinstein

Labels
investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Strip trailing whitespace and newlines when not autocorrecting. aclemons/ruumba
2 participants
@brendonrapp @ericqweinstein