Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beacon api v2.5.0 compatibility #12059

Open
errge opened this issue Sep 21, 2024 · 0 comments
Open

beacon api v2.5.0 compatibility #12059

errge opened this issue Sep 21, 2024 · 0 comments

Comments

@errge
Copy link
Contributor

errge commented Sep 21, 2024

Rationale

There is a change in the beacon api between 2.4.2 and 2.5.0: https://github.com/ethereum/beacon-APIs/blob/v2.5.0/apis/beacon/rewards/attestations.yaml#L34

The field called "execution_optimistic" is now required, and erigon doesn't provide it.

Therefore, if the API is used from a strict swagger generated client, we get an exception here, because erigon's answer is strictly speaking incorrect.

As a backstop, one can regenerate the client with 2.4.2 for now.

I also have a general question about this: I didn't find any documentation inside the repo or anywhere, that what is supposed to be the officially implemented beacon api version. This might be very useful for people, who want to call the API programatically through swagger, not just with small random curl or hand-programmed requests.

Implementation

I have no idea about the implementation and beacon api version inside erigon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant