Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade golangci-lint and investigate lost new-from-rev flag #12908

Open
AskAlexSharov opened this issue Nov 29, 2024 · 1 comment
Open

upgrade golangci-lint and investigate lost new-from-rev flag #12908

AskAlexSharov opened this issue Nov 29, 2024 · 1 comment
Assignees
Labels
imp2 Medium importance

Comments

@AskAlexSharov
Copy link
Collaborator

AskAlexSharov commented Nov 29, 2024

task to study how linter run, and rules in .golangci.yml
to take a look which linters are enabled/disabled, which todo are left there
why in Makefile we have #//--new-from-rev=$(MASTER_COMMIT) ./... - why not enable it (probably human-mistake. we want to lint code which changed by PR - even if PR has many commits. in my head it's "what changed from master")
remove lintci:

@AskAlexSharov AskAlexSharov added the imp2 Medium importance label Nov 29, 2024
@AskAlexSharov
Copy link
Collaborator Author

upgraded by #13048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imp2 Medium importance
Projects
None yet
Development

No branches or pull requests

2 participants