Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capi: fork validator last_pre_validated_block #2363

Open
battlmonstr opened this issue Sep 18, 2024 · 1 comment
Open

capi: fork validator last_pre_validated_block #2363

battlmonstr opened this issue Sep 18, 2024 · 1 comment
Labels
enhancement New feature or improvement

Comments

@battlmonstr
Copy link
Contributor

battlmonstr commented Sep 18, 2024

silkworm_start_fork_validator C API creates an ExecutionEngine with a BodiesStageFactory that has last_pre_validated_block providing 0. It means that full body validation will be performed even for bodies that have preverified hashes compiled.

In silkworm these bodies are pre validated using these hashes at the time of ingestion via the engine/execution API. If this happens in erigon too, this value could perhaps be passed from erigon inside SilkwormForkValidatorSettings, and make the body stage faster for historical blocks.

@battlmonstr battlmonstr added the enhancement New feature or improvement label Sep 18, 2024
@battlmonstr
Copy link
Contributor Author

CC @JacekGlen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

1 participant