Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: replace incremental with full mode in InterHashes stage #2596

Merged
merged 3 commits into from
Dec 19, 2024
Merged

node: replace incremental with full mode in InterHashes stage #2596

merged 3 commits into from
Dec 19, 2024

Conversation

canepat
Copy link
Member

@canepat canepat commented Dec 13, 2024 •
edited
Loading

Fixes #2597 by replacing incremental mode with full-regeneration mode also for small block intervals.

This is the output of the staged_pipeline debug_unwind command:

  INFO [12-13|23:37:26.132 UTC] Debug unwind datadir: ~/silkworm
  INFO [12-13|23:37:32.558 UTC] Reopen snapshot repository folder: ~/silkworm/snapshots
  INFO [12-13|23:37:34.978 UTC] Total reopened bundles: 72 max block available: 20'474'999
  INFO [12-13|23:37:34.978 UTC] Debug unwind: forward to=1'000'000 START
  INFO [12-13|23:37:34.978 UTC] ExecutionPipeline                        Forward start
  INFO [12-13|23:37:34.978 UTC] [5/13 Execution]                         op=kForward from=0 to=1000000 span=1000000 
  INFO [12-13|23:38:04.979 UTC] [5/13 Execution]                         block=808598 blocks/s=26953 txns/s=37097 Mgas/s=1520 
  INFO [12-13|23:38:18.284 UTC] Flushed state                            size=41.53 MB in=597.098ms 
  INFO [12-13|23:38:18.558 UTC] [5/13 Execution] commit                  batch time=272.511ms 
  INFO [12-13|23:38:18.560 UTC] [5/13 Execution]                         op=Forward done=43.581s 
  INFO [12-13|23:38:18.560 UTC] [6/13 HashState]                         op=kForward from=0 to=1000000 span=1000000 
  INFO [12-13|23:38:18.560 UTC] [6/13 HashState]                         clearing=HashedAccount 
  INFO [12-13|23:38:18.560 UTC] [6/13 HashState]                         clearing=HashedStorage 
  INFO [12-13|23:38:18.560 UTC] [6/13 HashState]                         clearing=HashedCodeHash 
  INFO [12-13|23:38:19.250 UTC] [6/13 HashState]                         op=Forward done=690.790ms 
  INFO [12-13|23:38:19.250 UTC] [7/13 IntermediateHashes] begin          op=kForward from=0 to=1000000 span=1000000 
  INFO [12-13|23:38:19.250 UTC] [7/13 IntermediateHashes]                clearing=TrieAccount 
  INFO [12-13|23:38:19.250 UTC] [7/13 IntermediateHashes]                clearing=TrieStorage 
  INFO [12-13|23:38:19.769 UTC] [7/13 IntermediateHashes]                op=Forward done=518.718ms 
  WARN [12-13|23:38:19.769 UTC] Stopping ...                             STOP_BEFORE_STAGE=HistoryIndex hit=true 
  INFO [12-13|23:38:19.778 UTC] ExecutionPipeline                        Forward done
  INFO [12-13|23:38:19.778 UTC] Debug unwind: forward to=1'000'000 END
  INFO [12-13|23:38:19.778 UTC] Debug unwind: unwind down to block=999'900 START
  INFO [12-13|23:38:19.778 UTC] ExecutionPipeline                        Unwind start
  INFO [12-13|23:38:19.779 UTC] [7/13 HashState]                         op=kUnwind from=1000000 to=999900 span=100 
  INFO [12-13|23:38:19.790 UTC] [7/13 HashState]                         op=Unwind done=11.738ms 
  INFO [12-13|23:38:19.790 UTC] [8/13 IntermediateHashes] begin          op=kUnwind from=1000000 to=999900 span=100 
  INFO [12-13|23:38:19.790 UTC] [8/13 IntermediateHashes]                clearing=TrieAccount 
  INFO [12-13|23:38:19.790 UTC] [8/13 IntermediateHashes]                clearing=TrieStorage 
  INFO [12-13|23:38:20.311 UTC] [8/13 IntermediateHashes]                op=Unwind done=520.911ms 
  INFO [12-13|23:38:20.311 UTC] [9/13 Execution]                         op=kUnwind from=1000000 to=999900 span=100 
  INFO [12-13|23:38:20.314 UTC] Erased 1'160 records from AccountChangeSet
  INFO [12-13|23:38:20.314 UTC] Erased 116 records from StorageChangeSet
  INFO [12-13|23:38:20.314 UTC] Erased 100 records from Receipt
  INFO [12-13|23:38:20.314 UTC] Erased 52 records from TransactionLog
  INFO [12-13|23:38:20.314 UTC] Erased 1'171 records from CallTraceSet
  INFO [12-13|23:38:20.318 UTC] [10/13 Senders]                          op=kUnwind from=20474999 to=999900 span=19475099 
  INFO [12-13|23:38:20.318 UTC] [11/13 Bodies]                           op=kUnwind from=20474999 to=999900 span=19475099 
  INFO [12-13|23:38:20.319 UTC] [12/13 BlockHashes]                      op=kUnwind from=20474999 to=999900 span=19475099 
  INFO [12-13|23:38:20.319 UTC] [13/13 Headers]                          op=kUnwind from=20474999 to=999900 span=19475099 
  INFO [12-13|23:38:20.346 UTC] ExecutionPipeline                        Unwind done
  INFO [12-13|23:38:20.346 UTC] Debug unwind: unwind down to block=999'900 END
  INFO [12-13|23:38:20.346 UTC] Debug unwind: forward+unwind success up to block=1'000'000

@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Dec 13, 2024
@canepat canepat marked this pull request as ready for review December 13, 2024 23:59
@battlmonstr battlmonstr merged commit 633836a into master Dec 19, 2024
6 checks passed
@battlmonstr battlmonstr deleted the fix/interhashes_disable_incremental_mode branch December 19, 2024 11:12
@canepat canepat mentioned this pull request Dec 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@battlmonstr battlmonstr battlmonstr approved these changes

@JacekGlen JacekGlen Awaiting requested review from JacekGlen

@bzawisto bzawisto Awaiting requested review from bzawisto

Assignees
No one assigned
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node: wrong state root after 100 blocks unwind
2 participants
@canepat @battlmonstr