Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: fix Windows build after ROTxn/RWTxn refactoring #1329

Merged
merged 1 commit into from
Jul 14, 2023
Merged

node: fix Windows build after ROTxn/RWTxn refactoring #1329

merged 1 commit into from
Jul 14, 2023

Conversation

canepat
Copy link
Member

@canepat canepat commented Jul 14, 2023

No description provided.

@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Jul 14, 2023
@canepat canepat requested a review from mriccobene July 14, 2023 10:22
@canepat canepat merged commit 1279043 into master Jul 14, 2023
@canepat canepat deleted the node_fix_win_build_txn_refactoring branch July 14, 2023 10:22
@battlmonstr
Copy link
Contributor

battlmonstr commented Jul 15, 2023 •
edited
Loading

@canepat this didn't fully work: https://github.com/torquem-ch/silkworm/actions/runs/5553078366/jobs/10141205339

@canepat
Copy link
Member Author

canepat commented Jul 15, 2023

@canepat this didn't fully work: https://github.com/torquem-ch/silkworm/actions/runs/5553078366/jobs/10141205339

Yep, fixed in #1334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mriccobene mriccobene Awaiting requested review from mriccobene

Assignees
No one assigned
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canepat @battlmonstr