Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back cute mode with hearts for battery segment #438

Closed
xx4h opened this issue Sep 10, 2024 · 1 comment
Closed

Bring back cute mode with hearts for battery segment #438

xx4h opened this issue Sep 10, 2024 · 1 comment

Comments

@xx4h
Copy link
Collaborator

xx4h commented Sep 10, 2024

After reviewing the in #435 mentioned commit (cab0747), it looks like all the changes were intentional.

Before that commit the two modes configured through TMUX_POWERLINE_SEG_BATTERY_TYPE:

  • percentage
  • cute
    were either displaying the current battery status in percentage, or by a number of hearts (cute).

The commit you mentioned has changed basically changed the looks of cute from hearts to a battery symbol.
So in general, nothing "broke", there's now just a new design for cute.

But to bring back the hearts, we should extend the possible values for TMUX_POWERLINE_SEG_BATTERY_TYPE by something like battery or symbol, to then have:

  • percentage (showing battery status in percentage)
  • symbol (showing battery status with battery symbol)
  • cute (showing battery status with as many hearts as defined in TMUX_POWERLINE_SEG_BATTERY_NUM_HEARTS )
@xx4h
Copy link
Collaborator Author

xx4h commented Oct 10, 2024

Fixed with #447

@xx4h xx4h closed this as completed Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant