Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Lens for including a header file when auto-completing an imported record name. #108

Closed
robertoaloi opened this issue Oct 20, 2019 · 3 comments
Closed

Code Lens for including a header file when auto-completing an imported record name. #108

robertoaloi opened this issue Oct 20, 2019 · 3 comments
Assignees
@alanz
Labels
code lenses feature

Comments

@robertoaloi
Copy link
Member

When pressing the '#' character, record names will be suggested for auto-complete (see #92 ). Whenever a record defined in a non-included header file is picked, a code lens should propose the user to include the header file.
@alanz alanz self-assigned this Dec 12, 2019
@alanz
Copy link
Contributor

alanz commented Dec 12, 2019

I think this is probably better done with a code action.

alanz added a commit to alanz/erlang_ls that referenced this issue Dec 12, 2019
@alanz
[erlang-ls#108] Add codeLens, codeAction and executeCommand plumbing.
d900419
alanz added a commit to alanz/erlang_ls that referenced this issue Dec 13, 2019
@alanz
[erlang-ls#108] Add codeLens, codeAction and executeCommand plumbing.
e55fcb3
@alanz
Copy link
Contributor

alanz commented Dec 16, 2019

The original intent of this issue can be achieved by returning a value for the additionalTextEdits?: TextEdit[]; field of the returned CompletionItem.

alanz added a commit to alanz/erlang_ls that referenced this issue Dec 20, 2019
@alanz
[erlang-ls#108] Add codeLens, codeAction and executeCommand plumbing.
93179d3
alanz added a commit to alanz/erlang_ls that referenced this issue Jan 6, 2020
@alanz
[erlang-ls#108] Add codeLens, codeAction and executeCommand plumbing.
48fd808
alanz added a commit to alanz/erlang_ls that referenced this issue Jan 10, 2020
@alanz
[erlang-ls#108] Add codeLens, codeAction and executeCommand plumbing.
a34e947
alanz added a commit to alanz/erlang_ls that referenced this issue Jan 14, 2020
@alanz
[erlang-ls#108] Add codeLens, codeAction and executeCommand plumbing.
ce85844
alanz added a commit to alanz/erlang_ls that referenced this issue Jan 16, 2020
@alanz
[erlang-ls#108] Add codeAction and executeCommand plumbing.
2a2543d 
This is intended to make the code action machinery available only,
without actually doing anything useful.
alanz added a commit to alanz/erlang_ls that referenced this issue Feb 28, 2020
@alanz
[erlang-ls#108] Add codeAction and executeCommand plumbing.
7e5b170 
This is intended to make the code action machinery available only,
without actually doing anything useful.
alanz added a commit that referenced this issue Mar 3, 2020
@alanz
Merge pull request #314 from alanz/108-code-lens
91cd825 
[#108] Add code action support
@plux
Copy link
Contributor

plux commented Oct 2, 2024

Added a code action to accomplish this:
#1510

@plux plux closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alanz alanz

Labels
code lenses feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@plux @robertoaloi @alanz