-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling shell arguments with different plugins #1322
Comments
You can just take the arguments from your own plugin and re-set them in the |
I believe this answer is all we have right now, no better way to do it without changing things in major ways. Will close this as answered. |
Would you have an example available on how to do this? |
Well, that's a 7 years old post, so I don't know that I would say the exact same today. We actually don't set them much in most places, but we do around things like code coverage: rebar3/apps/rebar/src/rebar_prv_eunit.erl Lines 551 to 557 in 837ccb0
It happens in this case that the coverage handler does not even check command line arguments, but that's how it would work. There's also some stuff in rebar_opts that can handle it: https://github.com/search?q=repo%3Aerlang%2Frebar3+rebar_opts%3Aset&type=code Most places that handle configuration check both for command-line arguments and for stuff set in rebar.config. So if your command reads it from the command line, it can write it to wherever the other config is handled and that will be the default in the command you call in turn. |
In relation to this. vans163/rebar3_auto#3
Running a plugin like rebar3_auto does not apparently allow to pass shell arguments.
Either you are running 'rebar3 auto', or you are running 'rebar3 shell name "node@localhost"'.
Perhaps add a way to support this, priority is minor.
The text was updated successfully, but these errors were encountered: