-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameters validation against schemas #44
Comments
I took some more time for looking into this direction.
This goes more into the direction of platform has to support this. Right now I am not 100% sure about the current #123 (will follow up on this). |
I also thing about doing some heavier lifting. -> Switch to FastAPI (use Python type hints and Pydantic schema validation) |
IMHO, validating parameters against schema in the broker make sense as we can free the broker writer from validating input data and get clearer error messages for users when parameters are wrong or missing. |
I like your package, it helped me quite a bit. I’m using it in a FastAPI application so having all of it in FastAPI would be nice. There is/was also fastbroker which sadly seems discontinued, maybe it can help as inspiration. Having input parameters validation against a schema would be a very helpful feature. |
I see the point of supporting easier schema validation. I am still not sure if it would be the right way to have it as a build in feature instead an opt in mechanism which can be easily setup via Pydantic. I will consider this for the roadmap 2022. Just to mention, I started to migrate this project to FastAPI Branch but did not make it, due to limited free time I could spend on this project. |
Is your feature request related to a problem? Please describe.
Every broker needs to implement validation.
Describe the solution you'd like
Implement a general solution in openbrokerapi.api module.
The text was updated successfully, but these errors were encountered: