Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters validation against schemas #44

Open
kazz-s opened this issue Nov 2, 2018 · 5 comments
Open

Add parameters validation against schemas #44

kazz-s opened this issue Nov 2, 2018 · 5 comments
Labels
enhancement nice to have Stories or issues are just a nice to have

Comments

@kazz-s
Copy link

kazz-s commented Nov 2, 2018

Is your feature request related to a problem? Please describe.
Every broker needs to implement validation.

Describe the solution you'd like
Implement a general solution in openbrokerapi.api module.

@eruvanos eruvanos added the nice to have Stories or issues are just a nice to have label Sep 30, 2019
@eruvanos
Copy link
Owner

I took some more time for looking into this direction.
From the spec I do not see any hint about service brokers should implement the validation:

Platforms MUST support at least JSON Schema draft v4

This goes more into the direction of platform has to support this.
Still, I like the general idea to add some meaning to the schemas.

Right now I am not 100% sure about the current #123 (will follow up on this).

@eruvanos
Copy link
Owner

I also thing about doing some heavier lifting.

-> Switch to FastAPI (use Python type hints and Pydantic schema validation)

@vaxvms
Copy link
Contributor

vaxvms commented Sep 28, 2020

IMHO, validating parameters against schema in the broker make sense as we can free the broker writer from validating input data and get clearer error messages for users when parameters are wrong or missing.

@holec
Copy link

holec commented Nov 21, 2020

I like your package, it helped me quite a bit. I’m using it in a FastAPI application so having all of it in FastAPI would be nice. There is/was also fastbroker which sadly seems discontinued, maybe it can help as inspiration.

Having input parameters validation against a schema would be a very helpful feature.

@eruvanos
Copy link
Owner

I see the point of supporting easier schema validation. I am still not sure if it would be the right way to have it as a build in feature instead an opt in mechanism which can be easily setup via Pydantic.

I will consider this for the roadmap 2022.

Just to mention, I started to migrate this project to FastAPI Branch but did not make it, due to limited free time I could spend on this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement nice to have Stories or issues are just a nice to have
Projects
None yet
Development

No branches or pull requests

4 participants