Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utf8 #182

Open
arty-name opened this issue Nov 13, 2024 · 2 comments
Open

utf8 #182

arty-name opened this issue Nov 13, 2024 · 2 comments

Comments

@arty-name
Copy link

The package is published 7 years ago but still has a million weekly downloads and 1k dependents. It doesn’t specify Node version.

Can be replaced by native TextEncoder.encode and TextDecoder.decode (both since Node 8.3) used with String.fromCharCode.apply().

@43081j
Copy link
Contributor

43081j commented Nov 15, 2024

good catch

although I cant seem to find where the downloads are coming from, so it may be that a lot are in private repos

the largest npm consumer seems to be this (at only ~200k/week):

https://www.npmjs.com/package/react-native-fs

@arty-name
Copy link
Author

arty-name commented Nov 15, 2024

Oh, React Native is a special beast. Apparently it uses a JS engine called Hermes by default, and while Hermes has added TextEncoder just in this year, support for TextDecoder is not high priority. Looks like this package might stick to utf8 for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants