You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While reading the submitted paper to JOSS, I noticed that the first paragraph of the "Statement of Need" section could be improved to make it more clear:
The complex gravitational fields of irregular bodies, such as asteroids and comets, are often modeled using polyhedral gravity models since alternative approaches like mascon models or spherical harmonics struggle with these bodies' irregular geometry. The former struggles with convergence close to the surface [@vsprlak2021use], whereas the latter requires a computationally expensive amount of mascons (point masses of which the target body is composed) to model fine-granular surface geometry [@wittick2017mascon].
The complex gravitational fields of irregular bodies, such as asteroids and comets, are often modeled using polyhedral gravity models since alternative approaches like mascon models or spherical harmonics struggle with these bodies' irregular geometry. The former struggles with convergence close to the surface [@vsprlak2021use], whereas the latter requires a computationally expensive amount of mascons (point masses of which the target body is composed) to model fine-granular surface geometry [@wittick2017mascon].
I think the usage of former and latter is not clear to which methods they are referring to. From the context, I understand that the former should refer to the spherical harmonics approach, while the latter should refer to the mascon models. If that's the case, the order of those are interchanged. Nonetheless, using former here might lead the reader to think it's referring to the polyhedral gravity models and not to one of the other methods.
Possible solution
I would suggest to modify that paragraph, explicitly mentioning the methods the sentence is referring to. Something along:
The complex gravitational fields of irregular bodies, such as asteroids and
comets, are often modeled using polyhedral gravity models since alternative
approaches like mascon models or spherical harmonics struggle with these
bodies' irregular geometry. The spherical harmonics approach struggles with
convergence close to the surface [@vsprlak2021use], whereas the mascon models
require a computationally expensive amount of mascons (point masses of which
the target body is composed) to model fine-granular surface geometry
[@wittick2017mascon].
I think it's ok to repeat the names of the methods in favor of clarity.
Please take this as a suggestion, and feel free to modify the paragraph at will.
The issue
While reading the submitted paper to JOSS, I noticed that the first paragraph of the "Statement of Need" section could be improved to make it more clear:
polyhedral-gravity-model/paper/paper.md
Line 48 in fa2dba3
I think the usage of former and latter is not clear to which methods they are referring to. From the context, I understand that the former should refer to the spherical harmonics approach, while the latter should refer to the mascon models. If that's the case, the order of those are interchanged. Nonetheless, using former here might lead the reader to think it's referring to the polyhedral gravity models and not to one of the other methods.
Possible solution
I would suggest to modify that paragraph, explicitly mentioning the methods the sentence is referring to. Something along:
I think it's ok to repeat the names of the methods in favor of clarity.
Please take this as a suggestion, and feel free to modify the paragraph at will.
This issue is part of the JOSS review: openjournals/joss-reviews#6384
The text was updated successfully, but these errors were encountered: