Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for --cache-from argument, or custom docker cli arguments #35

Closed
yevon opened this issue May 13, 2023 · 9 comments · Fixed by #38
Closed

Support for --cache-from argument, or custom docker cli arguments #35

yevon opened this issue May 13, 2023 · 9 comments · Fixed by #38
Assignees
Labels
enhancement New feature or request released

Comments

@yevon
Copy link

yevon commented May 13, 2023

Is it possible to specify the --cache-from docker argument to speed up the build speed in pipelines? Or specify other docker params outside build-args? I haven't seen this in the docs, thanks!

I have been using this plugin recently and is working very nicely.

@esatterwhite
Copy link
Owner

I think no in both cases. but it wouldn't be hard to allow for dockerArgs: []

@Dextererials
Copy link

Is it possible to specify the --cache-from docker argument to speed up the build speed in pipelines? Or specify other docker params outside build-args? I haven't seen this in the docs, thanks!

I have been using this plugin recently and is working very nicely.

The ability to provide params for docker would be great. Currently trying to pass a secret and there is no way to do this that I can see

@esatterwhite
Copy link
Owner

esatterwhite commented May 31, 2023

I see, could you post an example command?

@Dextererials
Copy link

Yes. For example docker build --secret id=ssh,src=~/.ssh/id_rsa --tag $CI_REGISTRY_IMAGE:$CI_COMMIT_SHA .

@esatterwhite
Copy link
Owner

@Dextererials Sorry for letting this sit so long. I'll take a look at it this week

@esatterwhite esatterwhite added the enhancement New feature or request label Jul 7, 2023
@esatterwhite esatterwhite self-assigned this Jul 7, 2023
@esatterwhite
Copy link
Owner

@yevon @Dextererials Would you expect this to accept template placeholders?

esatterwhite added a commit that referenced this issue Jul 10, 2023
includes support for the build flags cache-from and cache-to

fixes: #35
esatterwhite added a commit that referenced this issue Jul 10, 2023
includes support for the build flags cache-from and cache-to

fixes: #35
@esatterwhite esatterwhite linked a pull request Jul 10, 2023 that will close this issue
esatterwhite added a commit that referenced this issue Jul 10, 2023
includes support for the build flags cache-from and cache-to

fixes: #35
esatterwhite added a commit that referenced this issue Jul 11, 2023
includes support for the build flags cache-from and cache-to

fixes: #35
esatterwhite added a commit that referenced this issue Jul 11, 2023
includes support for the build flags cache-from and cache-to

fixes: #35
@github-actions
Copy link

🎉 This issue has been resolved in version 4.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@yevon
Copy link
Author

yevon commented Jul 12, 2023

Tested yesterday, working nicely thanks!

@Dextererials
Copy link

Just tested on my end as well and works great. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants