Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect return types for parseChunk and flush. #29

Open
muzam1l opened this issue May 19, 2024 · 1 comment
Open

Incorrect return types for parseChunk and flush. #29

muzam1l opened this issue May 19, 2024 · 1 comment

Comments

@muzam1l
Copy link

muzam1l commented May 19, 2024

The return types of functions parseChunk and flush are incorrectly typed as Iterator<T> in Typescript declarations while it is supposed to be Iterable<T>!

This makes Typescript error out for spread operator ... as well as for loops.

I can make the change if PR's are welcomed.

Thanks.
@eshaz
Copy link
Owner

eshaz commented May 20, 2024

Thanks for finding this. Pull requests are always welcomed and would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eshaz @muzam1l