Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github dev/release actions: windows build clobbers mac .dmg files #121

Open
esitarski opened this issue May 29, 2023 · 1 comment
Open

Comments

@esitarski
Copy link
Owner

Describe the bug
During the dev or release build, the mac dmg files are created in the first step, and are visible in the Release.
The windows .exe install files are created in the second step. However, when the exe files release, the .dmg files disappear.

To Reproduce
Steps to reproduce the behavior:

  1. Do a dev or release build.
  2. Watch the Releases area for the build.
  3. Note that the .dmg files are created by the mac step. This can be verified by refreshing the Release page.
  4. Notice that the .dmg files are no longer present after the windows step. This can be verified by checking the Release page after.
  5. Both the mac and windows steps complete successfully according to the log.

Expected behavior
All the .exe and .dmg install files are in the Release area after the build.

Context
The yaml file uses svenstaro/upload-release-action@v2.
This action appears to be called with all the correct parameters, however, this module also generates Node12 deprecation warnings, but svenstaro does not seem in any hurry to fix.
Possibly also related to svenstaro/upload-release-action#22 where uploaded assets are missing, however, the CrossMgr circumstances appear to be different.

Logs

The logs show some warnings, but nothing that indicates that the .dmg files are being deleted.

Windows Build Warning: Production Release Section:

Warning: Unexpected input(s) 'automatic_release_tag', valid inputs are ['repo_token', 'file', 'tag', 'asset_name', 'overwrite', 'promote', 'file_glob', 'prerelease', 'make_latest', 'release_name', 'body', 'repo_name']
Run svenstaro/upload-release-action@v[2](https://github.com/esitarski/CrossMgr/actions/runs/5105405225/jobs/9177026957#step:7:2)
  with:
    repo_token: ***
    automatic_release_tag: latest
    file: release/*
    tag: refs/tags/v[3](https://github.com/esitarski/CrossMgr/actions/runs/5105405225/jobs/9177026957#step:7:3).1.26-2023052812[4](https://github.com/esitarski/CrossMgr/actions/runs/5105405225/jobs/9177026957#step:7:4)3[5](https://github.com/esitarski/CrossMgr/actions/runs/5105405225/jobs/9177026957#step:7:5)2
    overwrite: true
    file_glob: true
  env:
    pythonLocation: C:\hostedtoolcache\windows\Python\3.10.11\x[6](https://github.com/esitarski/CrossMgr/actions/runs/5105405225/jobs/9177026957#step:7:6)4
    PKG_CONFIG_PATH: C:\hostedtoolcache\windows\Python\3.[10](https://github.com/esitarski/CrossMgr/actions/runs/5105405225/jobs/9177026957#step:7:10).[11](https://github.com/esitarski/CrossMgr/actions/runs/5105405225/jobs/9177026957#step:7:11)\x64/lib/pkgconfig
    Python_ROOT_DIR: C:\hostedtoolcache\windows\Python\3.10.11\x64
    Python2_ROOT_DIR: C:\hostedtoolcache\windows\Python\3.10.11\x64
    Python3_ROOT_DIR: C:\hostedtoolcache\windows\Python\3.10.11\x64

**Additional context**
[svenstaro](https://github.com/svenstaro)
/
[upload-release-action](https://github.com/svenstaro/upload-release-action)

Some have tried removing this options, but marvinpinto/actions#32 claims that it is still required even though it produces an error (?!?).

@esitarski
Copy link
Owner Author

.dmg files are there now, but all the .exe installs have "beta" in the names.
Not sure what is going on....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant