Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17.16.0 is not published on NPM #409

Closed
zloirock opened this issue Feb 23, 2025 · 7 comments
Closed

17.16.0 is not published on NPM #409

zloirock opened this issue Feb 23, 2025 · 7 comments
Labels

Comments

@zloirock
Copy link

zloirock commented Feb 23, 2025

Image Image
@zloirock zloirock added the bug label Feb 23, 2025
@voxpelli
Copy link
Member

Looks like tests are failing currently: https://github.com/eslint-community/eslint-plugin-n/actions/runs/13479442615

@voxpelli
Copy link
Member

We should make release-please bot use a bot account, so that tests gets run on its PR:s, that would help avoid this happening again

@aladdin-add
Copy link

It might be related to some recent type changes in eslint, I can take a deeper look at it later. But if anyone can help, that would be great! :)

@voxpelli
Copy link
Member

I’m sadly 110% occupied right now, else I would have loved to solve it

@scagood
Copy link

scagood commented Feb 27, 2025

It's 100% the changes to eslint, the options types are now {} (it used to be any), and it's had a wee knock one effect -- I tried to look last week, but ran out of time too.

Im gonna try to knock out a quick fix now

@scagood
Copy link

scagood commented Feb 27, 2025

A quick fix is here -- #411

The better fix is to fully type the rule options 🤔

@aladdin-add
Copy link

v17.6.1 was released: https://www.npmjs.com/package/eslint-plugin-n/v/17.16.1. Thanks for all your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants