Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need improved precision for Schmidt transform at high resolution #228

Open
tclune opened this issue Feb 21, 2024 · 1 comment · May be fixed by #229
Open

Need improved precision for Schmidt transform at high resolution #228

tclune opened this issue Feb 21, 2024 · 1 comment · May be fixed by #229
Assignees
@oehmke
Labels
who: unknown

Comments

@tclune
Copy link
Collaborator

tclune commented Feb 21, 2024

Bill Putman recently ran into an issue where DP gave bad results with the stretch provided by Schmidt transform.

The improvement is to use higher precision (where available) and use a different value of "TINY".

Quick summary here, but hopefully can point you to an FV PR soon.

ifdef NO_QUAD_PRECISION
! 64-bit precision (kind=8)                                                                             
 integer, parameter:: f_p = selected_real_kind(15)
#else
! Higher precision (kind=16) for grid geometrical factors:                                              
 integer, parameter:: f_p = selected_real_kind(20)
#endif

    near_zero = tiny(near_zero)
@mathomp4
Copy link
Contributor

I might actually be able to make a PR here for this. But I'll probably work with @tclune and the ESMF folks about handling that precision issue in a "nice" way to avoid having to add to build_config. (That is, I think NVHPC still doesn't support 128-bit.)

@mathomp4 mathomp4 linked a pull request Feb 26, 2024 that will close this issue
Open
@oehmke oehmke self-assigned this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oehmke oehmke

Labels
who: unknown
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Schmidt Transform for higher resolution GMAO-SI-Team/esmf
4 participants
@mathomp4 @tclune @danrosen25 @oehmke