Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where possible re-use the LP drivers in esp-hal proper #1192

Closed
MabezDev opened this issue Feb 21, 2024 · 1 comment
Closed

Where possible re-use the LP drivers in esp-hal proper #1192

MabezDev opened this issue Feb 21, 2024 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed low power Light-/Deep-Sleep and co-processor support

Comments

@MabezDev
Copy link
Member

A continuation from #1185 (review). I think we should be able to find a way to reuse drivers between HP and LP cores.

The idea of copy and pasting the driver terrifies me because they will get out of sync, no matter how hard we try.

@MabezDev MabezDev added bug Something isn't working help wanted Extra attention is needed low power Light-/Deep-Sleep and co-processor support labels Feb 21, 2024
@jessebraham
Copy link
Member

jessebraham commented Feb 21, 2024

Can we convert this to a discussion? It'd be nice to talk about this before jumping to conclusions on the best path forward. I need to look into both the HP and LP HALs and better understand the situation before I can really comment.

@esp-rs esp-rs locked and limited conversation to collaborators Feb 21, 2024
@MabezDev MabezDev converted this issue into discussion #1193 Feb 21, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Feb 21, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
bug Something isn't working help wanted Extra attention is needed low power Light-/Deep-Sleep and co-processor support
Projects
Archived in project
Development

No branches or pull requests

2 participants