Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpiDma Half duplex is hard to use #1236

Closed
MabezDev opened this issue Mar 4, 2024 · 3 comments
Closed

SpiDma Half duplex is hard to use #1236

MabezDev opened this issue Mar 4, 2024 · 3 comments
Assignees
@bjoernQ
Labels
peripheral:dma DMA Peripheral peripheral:spi SPI peripheral

Comments

@MabezDev
Copy link
Member

MabezDev commented Mar 4, 2024

The signatures for write and read require self which means we have to dance around moving it. Ideally, it should be possible with &mut self.

cc: @bjoernQ I believe you implemented this initially
@github-project-automation github-project-automation bot moved this to Todo in esp-rs Mar 4, 2024
@bjoernQ
Copy link
Contributor

bjoernQ commented Mar 4, 2024

All the DMA things currently look like that since the pattern resembles what some other HAL did before 😄
Maybe we could replace the move with some clever chosen lifetimes

@bjoernQ
Copy link
Contributor

bjoernQ commented Mar 4, 2024

Yes I think we can make things much simpler this way

@bjoernQ bjoernQ self-assigned this Mar 4, 2024
@MabezDev
Copy link
Member Author

Closed via #1238

@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjoernQ bjoernQ

Labels
peripheral:dma DMA Peripheral peripheral:spi SPI peripheral
Projects
esp-rs
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jessebraham @bjoernQ @MabezDev