Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variant usage #1304

Closed
burrbull opened this issue Mar 17, 2024 · 2 comments
Closed

variant usage #1304

burrbull opened this issue Mar 17, 2024 · 2 comments

Comments

@burrbull
Copy link
Contributor

Looks like you've found a hole in svd2rust API safety.

.write(|w| w.core_0_sp_min().variant(lower_bound));

@jessebraham
Copy link
Member

This seems unrelated to the HAL so I am going to close it. If I am mistaken please feel free to add more information and reopon.

@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Mar 19, 2024
@burrbull
Copy link
Contributor Author

variant should not be used for writing raw bytes. There is bits for this. Safe or unsually unsafe depending on writeConstrains values.
This is a hole that variant is possible to use there.
Trying to fix it with rust-embedded/svd2rust#825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants