Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is not possible to build the esp-hal package without the rt and vectored features enabled #1371

Closed
jessebraham opened this issue Apr 1, 2024 · 1 comment · Fixed by #1380
Closed

It is not possible to build the esp-hal package without the rt and vectored features enabled #1371

jessebraham opened this issue Apr 1, 2024 · 1 comment · Fixed by #1380
Assignees
@jessebraham
Labels
bug Something isn't working

Comments

@jessebraham
Copy link
Member

jessebraham commented Apr 1, 2024 •
edited
Loading

crate::interrupt::bind_interrupt() and crate::interrupt::enable() are both completely unavailable when the vectored feature is disabled, resulting in a number of build errors.

@MabezDev @bjoernQ what is the best course of action here?
@jessebraham jessebraham added the bug Something isn't working label Apr 1, 2024
@github-project-automation github-project-automation bot moved this to Todo in esp-rs Apr 1, 2024
@jessebraham jessebraham mentioned this issue Apr 1, 2024
Merged
@jessebraham jessebraham self-assigned this Apr 2, 2024
@jessebraham
Copy link
Member Author

We had a meeting today and have decided to simply remove these features for the time being. We can revisit this in the future if there is a need.

I will take care of removing these features.

@jessebraham jessebraham mentioned this issue Apr 2, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessebraham jessebraham

Labels
bug Something isn't working
Projects
esp-rs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Eliminate the rt and vectored features from the esp-hal package jessebraham/esp-hal
1 participant
@jessebraham