Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider resetting peripherals on driver construction #1880

Closed
bjoernQ opened this issue Jul 30, 2024 · 0 comments · Fixed by #1893
Closed

Consider resetting peripherals on driver construction #1880

bjoernQ opened this issue Jul 30, 2024 · 0 comments · Fixed by #1893
Assignees
@JurajSadel
Labels
status:needs-attention This should be prioritized
Milestone
0.20.0

Comments

@bjoernQ
Copy link
Contributor

bjoernQ commented Jul 30, 2024 •
edited
Loading

In some situations, peripherals can be left in undesired states - resetting the peripherals when the driver gets constructed might be a good thing to have generally

see #1524 (comment)
see #1847 (comment)
@jessebraham jessebraham added the status:needs-attention This should be prioritized label Jul 31, 2024
@JurajSadel JurajSadel self-assigned this Aug 1, 2024
@JurajSadel JurajSadel added this to the 0.20.0 milestone Aug 1, 2024
@JurajSadel JurajSadel mentioned this issue Aug 1, 2024
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JurajSadel JurajSadel

Labels
status:needs-attention This should be prioritized
Projects
esp-rs
Archived in project
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

Reset peripherals on driver construction (where missing) JurajSadel/esp-hal
3 participants
@jessebraham @bjoernQ @JurajSadel