-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make set_interrupt
panic free
#2760
Comments
The Xtensa |
Also, exposing |
Why is this a 1.0 blocker if we do not plan to stabilize interrupts? |
Whilst we aren't stabilizing the interrupt module, drivers in blocking mode should be able to set a interrupt handler. As it turns out, they can't right now: #2905. Once that's fixed, it becomes a bit more clear why this is a 1.0 blocker. This has also made me realize we do need to stabilize some things in the |
What about the |
As per #2900 (comment) we're not planning to stabilize interrupts, therefore I'm removing the 1.0-blocker label |
set_interrupt
implementations can panic becausePriority
contains theNone
variant.IIRC we use it internally for disabled interrupts so we cannot just remove it (also we transmute there - need to be cautious about that!)
One way would be to have an internal / HW priority and a user-facing priority - the later wouldn't include
None
(other solutions are also possible)The text was updated successfully, but these errors were encountered: